Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: in resolving extras for requirement #89

Open
pavel-hiiro opened this issue Aug 30, 2024 · 1 comment
Open

Bug: in resolving extras for requirement #89

pavel-hiiro opened this issue Aug 30, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@pavel-hiiro
Copy link

Hi! Thanks for a great library!

I believe there is a misspell in a checking parsing extras paths for requirements

	# Requirements
	if using == "requirements":
		requirementsPaths = ["requirements.txt"] if len(extras) > 0 else extras
		extras = []

which should be simply fixed by changing line to

		requirementsPaths = extras if extras else ["requirements.txt"]

which is consistent with the previous logic
ba70665#diff-3d2b023624ae6455c661f617085c9570286f1bed0e80cb02a65512d802aa19b4L58-L60

@pavel-hiiro pavel-hiiro added the bug Something isn't working label Aug 30, 2024
@FredHappyface
Copy link
Member

Hi sorry for the delay in getting back to you! Life has been busy

You're absolutely spot on, can't believe I introduced a bug there. I'll fix this asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants