Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Matrix for AGPL_3_PLUS #67

Closed
Sharpz7 opened this issue Jan 3, 2024 · 4 comments
Closed

Update Matrix for AGPL_3_PLUS #67

Sharpz7 opened this issue Jan 3, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Sharpz7
Copy link

Sharpz7 commented Jan 3, 2024

Hey,

I am going to need to use AGPLV3with my project, since I am using https://github.com/ultralytics/ultralytics which is under AGPLV3. This project looks perfect to me, and I would like to contribute.

First, I would want to add #43. It is GPL compatible which should make it easy to fill in the table.

Secondly, I think some lines in the matrix are wrong for AGPL:

  • AGPL Should be compatible with itself, currently it is not.
  • AGPL Should be compatible with Apache V2 (Apache work can be used in AGPL, not the other way round). https://www.apache.org/licenses/GPL-compatibility.html)
  • Since AGPL is compatible with GPLV3+, it should also be compatible with ZOTO.

I think separating out Apache V1 and Apache V2 would also be useful, since that is a compatibility problem. But use of Apache V1 is very limited so probably not needed

"The Free Software Foundation considers all versions of the Apache License to be incompatible with the previous GPL versions 1 and 2.[2] Furthermore, it considers Apache License versions before 2.0 incompatible with GPLv3"

From https://en.wikipedia.org/wiki/Apache_License

I am happy to add all these changes in a PR. Being able to choose the license in the CLI to use for the project would also be a nice touch I can add. Thanks!

Thanks in advance,
Adam

@Sharpz7 Sharpz7 added the enhancement New feature or request label Jan 3, 2024
@FredHappyface
Copy link
Member

Hi Adam,

Thank you so much for creating the issue, and your interest in the repo/ project :)

PRs are absolutely welcome! Usually I'd suggest splitting the features over a few PRs but am very happy to review them all together if that's something you're happy with?

Cheers again,
FredHappyface <3

@Sharpz7
Copy link
Author

Sharpz7 commented Jan 7, 2024

Yeah - just being able to get all this added in one PR would be great for me - the work is quite small in scale so hopefully that works.

I will get on this in the next week or two. Thanks!

@FredHappyface
Copy link
Member

Awsome stuff, thank you so much :)

@FredHappyface FredHappyface added this to the Next Version milestone Jan 27, 2024
@FredHappyface
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants