Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Automate Regression Testing #1904

Open
amygutierrez opened this issue Mar 9, 2023 · 3 comments · May be fixed by #1912
Open

✨ Automate Regression Testing #1904

amygutierrez opened this issue Mar 9, 2023 · 3 comments · May be fixed by #1912
Assignees
Labels
devops enhancement Epic feature potential idea For feature/change ideas that are still up for discussion or approval. testing

Comments

@amygutierrez
Copy link
Contributor

Related problem

Automate regression testing so that a regression test can be done whenever developer marks a pull request ready for review. This will allow for any bugs to be detected early and will give developers more time for debugging 👩‍💻

Proposed feature

  1. Create CLI tool called reg-suite. Have subcommands for cpac run and correlations. CLI tool will be portable enough to use locally and through git actions.
  2. Create lite and full version of the regression test. Lite version will run downsampled 5mm data (for faster runs) and full version will run complete datasets on all the pipelines.
  3. lite version will get triggered when pull request is ready for review. full version will get triggered when ready to merge to main

Acceptance criteria

automated regression test through git is more important.

Alternatives

No response

Additional context

No response

@amygutierrez amygutierrez added user-reported enhancement feature devops potential idea For feature/change ideas that are still up for discussion or approval. and removed user-reported labels Mar 9, 2023
@amygutierrez amygutierrez self-assigned this Mar 9, 2023
@amygutierrez amygutierrez moved this to 🏗 In progress in C-PAC Development Mar 9, 2023
@amygutierrez amygutierrez linked a pull request Mar 21, 2023 that will close this issue
8 tasks
@amygutierrez amygutierrez linked a pull request Mar 21, 2023 that will close this issue
8 tasks
@sgiavasis
Copy link
Collaborator

sgiavasis commented Apr 24, 2023

Updates:

  • The lite regression test automation is now operational, and will be triggered anytime a PR is ready for review.

Next:

  • Setup the lite regression test so that the results can be pulled easily.
  • Automation of the inputs into the correlation scripts.
  • Full regression test: structure needs to be changed (re: when it will run and which branch).
    • Has to run on ACCESS, so Singularity instead of Docker.
    • Different script compared to lite version.
  • Report generation.

@sgiavasis sgiavasis moved this from 🏗 In progress to 🚫 Blocked in C-PAC Development Apr 28, 2023
@sgiavasis
Copy link
Collaborator

Reminder here so I don't forget, and this should be a new issue/project - but it would be great if we set up some runs from fmriprep, ABCD, and CCS pipelines, save those outputs, and also automate correlations against the CPAC preconfigs for these pipelines.

@sgiavasis sgiavasis moved this from 🚫 Blocked to 🏗 In progress in C-PAC Development May 15, 2023
@sgiavasis sgiavasis moved this from 🏗 In progress to 🚫 Blocked in C-PAC Development May 30, 2023
@sgiavasis sgiavasis moved this from 🚫 Blocked to 🏗 In progress in C-PAC Development Jul 17, 2023
@shnizzedy shnizzedy added the Epic label Jul 25, 2023
@shnizzedy shnizzedy self-assigned this Jul 25, 2023
@shnizzedy
Copy link
Member

shnizzedy commented Jan 11, 2024

While I'm still working on simplifying all the necessary variables and secrets passing among the various repos for this feature repo map, here's a

preview of the first-draft of a comment the CI will push when the lite regression tests are run

https://github.com/FCP-INDI/C-PAC/commit/69d0a8853a8ffc439653db092ec2ec5555b01931#commitcomment-136282585

  • The Theodore Theodore bot account will post the comments. The example is me because I pushed it manually with my PAT while testing the final step.
  • The heatmap image in the comment links to an interactive version like this.
  • The upside to having all the various repos involved in this process is when issues like 🧑‍💻 Redesign boxplot setup CPAC_regtest_pack#10 are resolved, those improvements will be reflected in these automated comments.
  • I'm waiting until I have this flow working end-to-end to make all the various PRs ready-for-review, because I anticipate having to make changes in each of them before the whole thing works.
  • I'm doing a small amount of scaling up (adding a few subjects from multiple sites, changing the x-axis from site to subject) in this first draft.

@shnizzedy shnizzedy moved this from 🏗 In progress to 🚫 Blocked in C-PAC Development Feb 5, 2024
@shnizzedy shnizzedy moved this from 🚫 Blocked to 🏗 In progress in C-PAC Development Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops enhancement Epic feature potential idea For feature/change ideas that are still up for discussion or approval. testing
Projects
Status: 🏗 In progress
Development

Successfully merging a pull request may close this issue.

3 participants