Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESLint issues for Event.jsx #14

Open
readysetagile opened this issue Aug 6, 2022 · 5 comments
Open

Fix ESLint issues for Event.jsx #14

readysetagile opened this issue Aug 6, 2022 · 5 comments
Labels
CD/CD Related to Continuous Integration and continuous deployment Engineering Practices Issue is related to unit testing, coding standards, unit testing, etc. good first issue Good for newcomers

Comments

@readysetagile
Copy link
Collaborator

readysetagile commented Aug 6, 2022

Attempt to implement ESLint and TravisCI

Acceptance Criteria

GIVEN I am a Free Code Camp developer
WHEN I run npm run lint from a CLI
THEN I will see a lint report
AND the report will have 0 errors or problems

Guidance

@readysetagile readysetagile moved this from Ready for refinement - write the acceptance criteria (test script) for the feature to Ready for development - feature has a GitHub issue assigned and can be developed in FreeCodeCamp Columbus Website Aug 6, 2022
@readysetagile readysetagile changed the title Implement ESLint abd TravisCI Implement ESLint and TravisCI Aug 6, 2022
@readysetagile
Copy link
Collaborator Author

Note ESLint was imlpemented with Prettier implementation, however npm run lint is generating an error

@readysetagile
Copy link
Collaborator Author

today - 7 errors. need to discuss how severe these are.

@readysetagile
Copy link
Collaborator Author

>npm run lint

> [email protected] lint
> eslint . --ext js,jsx,ts,tsx --fix

Browserslist: caniuse-lite is outdated. Please run:
  npx update-browserslist-db@latest
  Why you should do it regularly: https://github.com/browserslist/update-db#readme

C:\repos\cbus-web\src\components\Event.jsx
   1:18   error  'event' is missing in props validation              react/prop-types
   1:25   error  'id' is missing in props validation                 react/prop-types
   4:120  error  'event.time' is missing in props validation         react/prop-types
  17:20   error  'event.name' is missing in props validation         react/prop-types
  26:26   error  'event.location' is missing in props validation     react/prop-types
  30:19   error  'event.description' is missing in props validation  react/prop-types

C:\repos\cbus-web\src\setupTests.js
  5:1  error  '@testing-library/jest-dom' should be listed in the project's dependencies, not devDependencies  import/no-extraneous-dependencies

✖ 7 problems (7 errors, 0 warnings)

@readysetagile
Copy link
Collaborator Author

I removed the TravisCI requirement from the issue because the CI is covered by Netlify and our process

However we need to re-configure the linter or fix the errors before proceeding. I am leaning toward fixing the errors

@readysetagile readysetagile changed the title Implement ESLint and TravisCI Implement ESLint Aug 28, 2023
@readysetagile readysetagile changed the title Implement ESLint Fix ESLint issues for Event.jsx Aug 30, 2023
@readysetagile
Copy link
Collaborator Author

Since this is likely going to be our next set of dev tasks we will want to resolve these issues.

I did some further research. Event.jsx is a child component of Events.jsx. Perhaps this StackOverflow article will help. We will want to most likely add a .propTypes validator for each of the properties.

@mmcbride2929 mmcbride2929 moved this from Ready for development to Code Review in FreeCodeCamp Columbus Website Aug 31, 2023
@readysetagile readysetagile moved this from Code Review to Ready to be staged in FreeCodeCamp Columbus Website Sep 1, 2023
@readysetagile readysetagile moved this from Ready to be staged to Ready for Testing in FreeCodeCamp Columbus Website Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CD/CD Related to Continuous Integration and continuous deployment Engineering Practices Issue is related to unit testing, coding standards, unit testing, etc. good first issue Good for newcomers
Projects
Status: Ready for Testing
Development

No branches or pull requests

1 participant