Merge pull request #376 from Eyevinn/fix-lint-issues

chore: fix new golangci-lint issues
Eyevinn · Sep 10, 2024 · bdea2fb · bdea2fb
2 parents 1142615 + cf4665c
commit bdea2fb
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/cmd/mp4ff-pslister/main.go b/cmd/mp4ff-pslister/main.go
@@ -392,7 +392,7 @@ func printPS(name string, nr int, ps []byte, psInfo interface{}, verbose bool) {
 	if verbose && psInfo != nil {
 		jsonPS, err := json.MarshalIndent(psInfo, "", "  ")
 		if err != nil {
-			log.Fatalf(err.Error())
+			log.Fatalln(err.Error())
 		}
 		fmt.Printf("%s\n", string(jsonPS))
 	}

diff --git a/mp4/file_test.go b/mp4/file_test.go
@@ -54,7 +54,7 @@ func TestDecodeFileWithNoLazyMdatOption(t *testing.T) {
 			if frag.Mdat.lazyDataSize != 0 {
 				t.Error("decLazyDataSize is expected to be 0")
 			}
-			if frag.Mdat.Data == nil || len(frag.Mdat.Data) == 0 {
+			if len(frag.Mdat.Data) == 0 {
 				t.Error("Mdat Data is expected to be non-nil")
 			}
 		}

diff --git a/mp4/helpers_test.go b/mp4/helpers_test.go
@@ -124,7 +124,7 @@ func assertNoError(t *testing.T, err error) {
 func assertError(t *testing.T, err error, msg string) {
 	t.Helper()
 	if err == nil {
-		t.Errorf(msg)
+		t.Error(msg)
 	}
 }
 

diff --git a/mp4/pssh_test.go b/mp4/pssh_test.go
@@ -26,7 +26,7 @@ func TestPsshFromBase64(t *testing.T) {
 	d := deep.Equal(buf.String(), expected)
 	if len(d) > 0 {
 		for _, l := range d {
-			t.Errorf(l)
+			t.Error(l)
 		}
 	}
 }