Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review instance id/url with packages #549

Open
SferaDev opened this issue Jul 10, 2020 · 0 comments
Open

Review instance id/url with packages #549

SferaDev opened this issue Jul 10, 2020 · 0 comments

Comments

@SferaDev
Copy link
Contributor

SferaDev commented Jul 10, 2020

  • For packages we are storing the url as the instance, but not the instance id itself. As a work-around we try to match by url too, but this should be rethinked.

See:

private async getInstanceById(id: string): Promise; -> GenericSyncUseCase

PD: Not sure if that's the case anymore, this task is only to review and double check it.

@SferaDev SferaDev self-assigned this Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant