[feature]: Save AMR questionnaire on button click #310
Conversation
deeonwuli
changed the title
| private getDataValuesForQuestion(questionnaire: QuestionnaireSelector, question: Question): D2DataValue[] { | ||
| const { type } = question; | ||
| const { orgUnitId, year } = questionnaire; | ||
| private getDataValuesForQuestions(questionnaire: QuestionnaireSelector, questions: Question[]): D2DataValue[] { |
There was a problem hiding this comment.
Proposal: as the "singular" method already exists, instead of refactoring it to make it "plural" (which creates an extra indentation level), let's create a new method getDataValuesForQuestions that uses the old (untouched) getDataValuesForQuestion. This will also prevent your name from showing in the "blame" for a code that is not yours :)
| execute(questionnaire: QuestionnaireSelector, question: Question) { | ||
| return this.questionnaireReposotory.saveResponse(questionnaire, question); | ||
| execute(questionnaire: QuestionnaireSelector, questions: Question[]) { | ||
| return this.questionnaireReposotory.saveResponse(questionnaire, questions); |
There was a problem hiding this comment.
let's fix the old typo: Reposotory
| onClick={saveQuestionnaire} | ||
| disabled={disableSave} | ||
| > | ||
| Save Questionnaire |
| return [...prevState, newQuestion]; | ||
| } | ||
|
|
||
| return prevState.map(question => (question.id === newQuestion.id ? newQuestion : question)); |
There was a problem hiding this comment.
Being the last expression of the block, let's do a if/else.
| const validationErrors = useMemo(() => { | ||
| return questionnaire?.sections.flatMap(section => | ||
| _(section.questions) | ||
| .map(question => (question.validationError ? question.validationError : undefined)) |
| snackbar.error(err); | ||
| } | ||
| ); | ||
| }, [compositionRoot.questionnaires, questionnaire, questionsToSave, savingActions, snackbar]); |
There was a problem hiding this comment.
This callback is running an effect, so it should be using useEffect (so it can be cancelled). This could be done with a useCallback+useState+useEffect, but we already have this common pattern abstracted: useCallbackEffect. See some usages in the app.
…into feat/update-validation-rules-for-amr-questionnaire
📌 References
📝 Implementation
Metadata changes
The data element formNames in dataSet AMR_AMR_DS_Questionnaire_Implementation [
OYc0CihXiSn] have been modified to include the prefixQn(where n is the question number).📹 Screenshots/Screen capture
Screen.Recording.2024-12-02.at.15.38.20.mov
🔥 Testing
#8696nnwfh