Coding Dojo : Create custom hooks for presentation logic, modularise large functions <DO NOT MERGE> #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9sneha-n
commented
Apr 12, 2024
| @@ -31,3 +33,15 @@ export type NonBlockingError = { | |||
| type: "non-blocking"; | |||
| error: ConsistencyError; | |||
| }; | |||
|
|
|||
| export interface ImportOptions { | |||
| orgUnitName: string; | ||
| countryCode: string; | ||
| dryRun: boolean; | ||
| eventListId: string | undefined; |
There was a problem hiding this comment.
use Id wherever applicable. use Maybe<>
| dryRun: boolean, | ||
| eventListId: string | undefined | ||
| ): FutureData<ImportSummary> { | ||
| public execute(inputFile: File, options: ImportOptions): FutureData<ImportSummary> { |
There was a problem hiding this comment.
for future projects : do not pass file to domain, as it is not a domain entity
| orgUnitName: currentOrgUnitAccess.orgUnitName, | ||
| countryCode: currentOrgUnitAccess.orgUnitCode, | ||
| dryRun: false, | ||
| eventListId: "", |
There was a problem hiding this comment.
so not pass empty string
| }; | ||
| const secondaryUploadId = localStorage.getItem("secondaryUploadId"); | ||
| const params = { | ||
| primaryUploadId: "", |
There was a problem hiding this comment.
ideally we should not pass empty strings
| } | ||
| }, [batchId, isPrimaryFileValid, isSecondaryFileValid, moduleName]); | ||
|
|
||
| const changeBatchId = async (event: React.ChangeEvent<{ value: unknown }>) => { |
| } | ||
| ); | ||
| }, [compositionRoot.fileSubmission, snackbar, orgUnitId, moduleName, orgUnitCode, uploadFileType, setLoading]); | ||
|
|
| const primaryUploadId = localStorage.getItem("primaryUploadId"); | ||
| const secondaryUploadId = localStorage.getItem("secondaryUploadId"); | ||
| if (secondaryUploadId && primaryUploadId) | ||
| compositionRoot.glassDocuments.updateSecondaryFileWithPrimaryId(secondaryUploadId, primaryUploadId).run( |
There was a problem hiding this comment.
usecallbackeffect in all functions
| if (secondaryFile) { | ||
| validate(true); | ||
| } else { | ||
| validate(false); |
There was a problem hiding this comment.
validate(Boolean(secondaryFile))
|
|
||
| export function useSecondaryFile( | ||
| secondaryFile: File | null, | ||
| setSecondaryFile: React.Dispatch<React.SetStateAction<File | null>>, |
There was a problem hiding this comment.
chaneg null to undefined
9sneha-n
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
📹 Screenshots/Screen capture
🔥 Testing