Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure iOS share extension can load files of all types, from all apps #290

Open
lindboe opened this issue Dec 6, 2023 · 0 comments
Open

Comments

@lindboe
Copy link

lindboe commented Dec 6, 2023

We've encountered issues with being able to consistently load file data from all apps. It seems individual apps are responsible for constructing their own data to share to the point that they don't all behave the same. In addition, with some changes, we've seen apps work on the simulator but not a physical device (i.e., Photos).

Example 1: Files app

Upon trying to share a file from the Files app on iOS, the share extension will crash here. The data object provided by the Files app cannot be past to a URL, but the data object in the same method provided by the photos app is a URL.

To fix this, we changed forTypeIdentifier to kUTTypeFileUrl, which makes the apps on the simulator work correctly. However, upon testing on a physical device, shares from the Photos app start crashing with this change instead.

In scope:

  • Find a way to update storeFile such that it can handle file shares from a wide variety of apps. Test the changes both on the simulator (sharing from Photos and Files apps), as well as on a physical device (Photos, Files, in addition to other apps like Google Drive, etc).

Out of scope:

@lindboe lindboe changed the title Ensure iOS share extension can access load files of all types, from all apps Ensure iOS share extension can load files of all types, from all apps Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant