Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SUGGESTION] Update harmony, use built-in PatchCategory #2537

Open
moddedmcplayer opened this issue Apr 30, 2024 · 2 comments
Open

[SUGGESTION] Update harmony, use built-in PatchCategory #2537

moddedmcplayer opened this issue Apr 30, 2024 · 2 comments
Assignees
@NaoUnderscore
Labels
dependencies Pull requests that update a dependency file P2 Medium priority

Comments

@moddedmcplayer
Copy link
Contributor

title
@moddedmcplayer moddedmcplayer added the requires-testing Things need to be verified by an Exiled Developer/Contributor label Apr 30, 2024
@moddedmcplayer
Copy link
Contributor Author

A lot of the stuff in https://github.com/Exiled-Team/EXILED/blob/dev/Exiled.API/Features/GlobalPatchProcessor.cs and https://github.com/Exiled-Team/EXILED/blob/master/Exiled.Events/Features/Patcher.cs is now part of harmony itself, see https://harmony.pardeike.net/articles/basics.html#patching-using-annotations.

@louis1706 louis1706 added dependencies Pull requests that update a dependency file P2 Medium priority and removed requires-testing Things need to be verified by an Exiled Developer/Contributor labels May 1, 2024
@ALEXWARELLC
Copy link
Member

@NaoUnderscore Any plans to use PatchCategory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NaoUnderscore NaoUnderscore

Labels
dependencies Pull requests that update a dependency file P2 Medium priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@NaoUnderscore @louis1706 @moddedmcplayer @ALEXWARELLC