Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mapper variable name in PropertyCaster #61

Open
shadowhand opened this issue Dec 15, 2023 · 1 comment
Open

Update mapper variable name in PropertyCaster #61

shadowhand opened this issue Dec 15, 2023 · 1 comment

Comments

@shadowhand
Copy link
Contributor

The current definition has a variable named "hydrator":

interface PropertyCaster
{
    public function cast(mixed $value, ObjectMapper $hydrator): mixed;
}

It used to be that ObjectMapper was called ObjectHydrator, which is likely why this variable has the name it does. Changing this will require a major release, but I think it should be:

interface PropertyCaster
{
    public function cast(mixed $value, ObjectMapper $mapper): mixed;
}

My editor would really like this, because it doesn't think "hydrator" is a word. And of course, it would make the signature more consistent.

@frankdejonge
Copy link
Member

This will be handled in league/object-mapper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants