Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly implement aggregate root versioning #16

Open
driesvints opened this issue Mar 12, 2020 · 4 comments
Open

Properly implement aggregate root versioning #16

driesvints opened this issue Mar 12, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@driesvints
Copy link
Contributor

We'll need to properly implement versioning in the database table and retrieve it from the last record in the retrieveAll method of the LaravelMessageRepository and also implement the retrieveAllAfterVersion method.
@driesvints driesvints added the enhancement New feature or request label Mar 12, 2020
@driesvints driesvints mentioned this issue Mar 12, 2020
Merged
@sandervanhooft
Copy link
Contributor

@driesvints do you have some specific ideas on this?

@sandervanhooft
Copy link
Contributor

Version would be just an (not auto) incrementing int right?

@driesvints
Copy link
Contributor Author

@sandervanhooft it's been quite a while since I worked on the library and probably won't have time to check into this soon, sorry. I still plan on working on it eventually but don't know when I'll get to it.

@sandervanhooft
Copy link
Contributor

No problem!

And I yet have to encounter my first concurrency issue with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
2 participants
@driesvints @sandervanhooft