Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in tx data decoding (token transfers & account balances sections) #163

Open
shreyjain711 opened this issue May 8, 2022 · 3 comments · Fixed by #162
Open

Bug in tx data decoding (token transfers & account balances sections) #163

shreyjain711 opened this issue May 8, 2022 · 3 comments · Fixed by #162
Labels
bug Something isn't working

Comments

@shreyjain711
Copy link

Referring to this tx on etherscan, address 0x8c3FA50473065f1D90f186cA8ba1Aa76Aee409Bb is receiving 0.01 eth
but as per the tx on ethtx.info the address is sending out the same amount.

The emitted events show it as a donation sent event which would indicate the aforementioned address should be the recipient of the amount rather than the one sending it, and hence, I'm inclined to believe that the decoding on etherscan is correct and ethtx's isn't.

I tried to make some more sense of the data and these points might help with debugging the issue:
0x8c3f.. is a gnosis safe multisig. Ethtx shows 0x8c3f.. is sending the eth to 0x34cf.., this recipient is actually the gnosis safe mastercopy contract. I think this is where the problem lies. this mastercopy be receiving the funds from the multisig doesn't seem right to me

@kchojn kchojn added the bug Something isn't working label May 9, 2022
@CaledoniaProject
Copy link

Same problem, please fix it ASAP.

111

@rmaganza
Copy link
Collaborator

Referring to this tx on etherscan, address 0x8c3FA50473065f1D90f186cA8ba1Aa76Aee409Bb is receiving 0.01 eth but as per the tx on ethtx.info the address is sending out the same amount.

The emitted events show it as a donation sent event which would indicate the aforementioned address should be the recipient of the amount rather than the one sending it, and hence, I'm inclined to believe that the decoding on etherscan is correct and ethtx's isn't.

I tried to make some more sense of the data and these points might help with debugging the issue: 0x8c3f.. is a gnosis safe multisig. Ethtx shows 0x8c3f.. is sending the eth to 0x34cf.., this recipient is actually the gnosis safe mastercopy contract. I think this is where the problem lies. this mastercopy be receiving the funds from the multisig doesn't seem right to me

Hello!

This issue should be fixed with the following PR to the backend (#162).
You can already test locally by cloning ethtx repo. We will deploy it soon in the next release.

@kchojn kchojn pinned this issue Aug 10, 2022
@kchojn kchojn unpinned this issue Aug 10, 2022
@kchojn kchojn transferred this issue from EthTx/ethtx_ce Aug 10, 2022
@kchojn kchojn linked a pull request Aug 10, 2022 that will close this issue
@antazoey
Copy link

The hash in the issue works now so this issue can probably be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants