Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UMD bundles include arcgis-rest-js dependencies #487

Open
tomwayson opened this issue Apr 1, 2021 · 1 comment
Open

UMD bundles include arcgis-rest-js dependencies #487

tomwayson opened this issue Apr 1, 2021 · 1 comment

Comments

@tomwayson
Copy link
Member

If you search the UMD bundle for "queryFeatures" you'll see the source for that function (as well as the source decodeValues() and request(), etc. This is despite the fact that it's marked as external:

external: [
'@esri/arcgis-rest-feature-service'
],

What makes this worse is that package.main points the the UMD build:

"main": "dist/umd/cedar.js",

Originally the thinking was that we didn't want to bother making a CJS build and node could just load the UMD bundle, but now bundlers like webpack that prefer main over module will use this UMD bundle by default.

@tomwayson
Copy link
Member Author

Ooops, looks like we forgot to update the profile to @esri/arcgis-rest-feature-layer

} from '@esri/arcgis-rest-feature-layer'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant