Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of error messages #123

Open
crehop opened this issue Nov 29, 2016 · 2 comments
Open

Lack of error messages #123

crehop opened this issue Nov 29, 2016 · 2 comments

Comments

@crehop
Copy link

crehop commented Nov 29, 2016

When sending custom packets, if you don't have a default constructor for one of the registered classes and attempt to send, no error message is displayed on client or server, yet the packet is not received. additionally if the packet isn't received for other reasons, no error is thrown either.. you're left just guessing whats wrong.. please add error messages to these types of events. Thank you.

@crehop
Copy link
Author

crehop commented Nov 29, 2016

Example

public class Packet2QueueMessage {
public Packet2QueueMessage(int i){
}
}

would not be recognized,would not be sent, and no error message would be thrown.

public class Packet2QueueMessage {
public Packet2QueueMessage(){}
public Packet2QueueMessage(int i){
}
}

would be recognized and sent

@crehop
Copy link
Author

crehop commented Nov 29, 2016

Additionally if your classes don't match exactly, they wont send, and don't throw error messages.

Example

Server

  public enum Reminder{
	  DAILY_UNTIL_SIGNED("DAILY"),
	  WEEKLY_UNTIL_SIGNED("WEEKLY"),
	  NONE_SET("");
	  private String value;

	  Reminder(String value) {
	    this.value = value;
	  }
}

Client

public enum Reminder{
     DAILY_UNTIL_SIGNED("DAILY"),
     WEEKLY_UNTIL_SIGNED("WEEKLY"),
     private String value;

     Reminder(String value) {
       this.value = value;
     }
}

Packet will work as normal as long as NONE_SET isn't chosen, in which case no error will be thrown and the packet just wont send.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant