Class modifiers on non-T4/Handlebars items (specifically sprocs)

[jwyza-pi]

I know in previous issue requests, that folks have requested the ability to change the class access modifiers for the stored procedures. The answer currently stands as making that a post-scaffolding operation. Now that we have complete control over the EntityTypeConfigurations through the T4 templates, this is one of the last remaining places that we can't customize.

Would you be open to a enhancement PR that would add (at the very least) a setting for the class access modifiers for the related classes generated for stored procedures as an option to the CLI? I wouldn't be able to easily do the GUI side of it, but could handle getting all the code in place so that it works for the CLI (which if I understand how the GUI works, it's mostly just hooking the GUI itself up as both share the same underlying code to do the actual generation).

If you are open to it, I'll see what it would take to accomplish, if not, that's OK too. I understand that it adds overhead to the application that you have to maintain going forward.

(Honestly, long term I'd be great to have T4 & handlebars templates for everything, but that's a substantially heavier lift).

Provide technical details

• EF Core Power Tools version: 8.1.624+2406c890c03798082722e1f757e32be8f82d5bb4

• Exact Visual Studio version: N/A

• Database engine: Azure SQL

• EF Core version in use: EFC8

• Is Handlebars templates used: no

• Is T4 templates used: yes

• Is a SQL Server .dacpac used: no

[ErikEJ]

Sure, I think it will be not so hard to do, just stick to the CLI implementation. I assume you are referring to the result set classes for "routines"?

[jwyza-pi]

It's the [DbContextName]Procedures (partial class of [DbContextName]), I[DbContextName]Procedures, DbContextExtensions, and OutputParameter<TValue> classes that all would need to follow whatever the access modifier is.

Not sure if the extensions and outputparameter classes are used by the Functions output, if they are, then those would also probably need to have the same treatment.

[ErikEJ]

Ouch! DbContextExtensions, and OutputParameter<TValue> are going to be tricky! Maybe they can just be included in the [DbContextName]Procedures class?

[jwyza-pi]

It's surely possible, but I'm worried about that breaking folks downstream since the namespace of those classes would then change :(.

I take it those 2 classes are used much more than just the sprocs?

[ErikEJ]

I think they are only used by the sprocs, so they could be generated, or you could add a replacement tag for the modifier?

[jwyza-pi]

Yeah. just like #NAMESPACE# is currently done for it.

And then updating the procedureScaffolder base class to use the access modifier when writing out the context files.

So I think it's updating ProcedureScaffolder, PostgressStoredProcedureScaffolder and SqlServerStoredProcedureScaffolder. (along with the files needed for setting itself).