Remove audit logs #1698
Merged
Remove audit logs #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure I would be leaning on fully removing them though. I would rather just have it provide a more userfriendly interface to oldlogs, or fix the mentioned problems in the issue and otherwise keeping it. But it's your choice maybe it's better to totslly remove it, after all it replicates the behavior of oldlogs. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Oh wait this was already merged. |
|
Haha literally 8 minutes ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1694 for reasoning
What part of Adonis is this related to: Audit logs feature #1568
Draft until other adonis issues are resolved to allow for a PoF