Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do something about audit logs #1694

Closed
ccuser44 opened this issue Nov 9, 2024 · 4 comments
Closed

Do something about audit logs #1694

ccuser44 opened this issue Nov 9, 2024 · 4 comments
Labels
🐛 bug Bugs or broken features

Comments

@ccuser44
Copy link
Contributor

ccuser44 commented Nov 9, 2024

Version channel

Nightly

Loader version

Nightly

What part of Adonis is this related to?

Other

What happened?

There are so many problems with Audit logs.

  • They just errors and lags in studio.
  • They don't respect any datastore saving settings
  • They cause massive datastore spam due to every command that uses audit logs always saving to a datastore.
  • Code is very error prone
  • The implementation inappropriately shares code between different Adonis modules
  • Dublicates functionality of oldlogs
  • The code doesn't use proper Adonis datastore mechanisms
  • Numerous other issues

Something should be done, either about the issues or about auditlogs.

Steps to reproduce

N/A

Device

Windows

Relevant log output

No response

@ccuser44 ccuser44 added the 🐛 bug Bugs or broken features label Nov 9, 2024
@ccuser44
Copy link
Contributor Author

ccuser44 commented Nov 9, 2024

Related #1588

@Dimenpsyonal
Copy link
Member

Once something is done about audit logs I can release v260. You're welcome to submit a PR to either remove them or fix them and I'll merge either

@ccuser44
Copy link
Contributor Author

ccuser44 commented Nov 9, 2024

Once something is done about audit logs I can release v260

Its not. There ae numerous problems (including breaking bugs) and pulls to be merged to fix them

@Dimenpsyonal
Copy link
Member

Fixed by #1698

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Bugs or broken features
Projects
None yet
Development

No branches or pull requests

2 participants