Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot reload configuration from configmap without needing pod restart #18

Open
amitai-devops opened this issue Dec 20, 2022 · 2 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@amitai-devops
Copy link
Collaborator

No description provided.

@amitai-devops amitai-devops added enhancement New feature or request good first issue Good for newcomers labels Dec 20, 2022
@Charlie17Li
Copy link

As far as I know, the k8s can support the reload of the configMap without restating the pods. link

I want to try this, but I can't figure out anything else we should do. Could you give me some advice?

@amitai-devops
Copy link
Collaborator Author

amitai-devops commented Dec 26, 2022

First of all thank you for the contribution!

I haven't had a chance to look at this one yet. What we want is to basically load the flags and the custom configuration of the controller without requiring restart which is of course possible like you said. I would just make the controller try to read a configmap if one is available and use the flags from there.
Also you need to decide if the configmap overrides the flags or vice versa. That's up to you!

I didn't really understand the question thou, I'm available to clarify anything that is needed

@Charlie17Li

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants