Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are 2 Items with the name "Tank", making them undistinguishable on import #17

Open
KevinCCucumber opened this issue Feb 19, 2022 · 4 comments

Comments

@KevinCCucumber
Copy link

There is the clothing item tank and also the furniture item tank, breaking the function to parse the list of item names to get its contents.
Adding an additonal api output, like e.g. unique IDs from the ACNH spreadsheet could solve this problem for non-variant items.

However, I currently have no idea how this issue could be solved.

@EhsanKia
Copy link
Owner

Are these both from Catalog scan? Which tabs/sections are they from? Note that CatalogScanner is also only scanning text, so it can't tell them apart either, though I assume from the context it could infer it. But then, the same could be true of whatever loads the items.

Changing how the API words would probably be just as much work for apps to implement.

Is it possible to have both "tanks" in the same list? I don't think so right since they are in different categories.

@KevinCCucumber
Copy link
Author

Tank Furniture (Housewares):
image
Tank Clothing (Tops):
image

Since scanning the normal catalog should contain cothing as well as furniture, there will most likely be 2 tank items right next to each other in the list, making it indistinguishable from each other if its the cloth or the piece of furniture. Just having the name "tank" in the list could mean any of these 2 items.

@EhsanKia
Copy link
Owner

Hmm, interesting. I'm curious, do you have such a video / screenshot showing both of them side by side?

@KevinCCucumber
Copy link
Author

I dont own the items. I may take some time to get a screenshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants