Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support more form factors #509

Open
1 task done
EdricChan03 opened this issue Dec 7, 2023 · 0 comments
Open
1 task done

[Feature] Support more form factors #509

EdricChan03 opened this issue Dec 7, 2023 · 0 comments
Labels
comp: design Issues/PRs related to the app's design. enhancement Enhancements to the Android app. For the web version, please use the other repo instead. in progress PRs that are still not finished yet and/ or not yet ready for merging. user interface Issues/PRs related to the mentioning/fixing of the UI.

Comments

@EdricChan03
Copy link
Owner

Is there an existing issue for this?

  • I have searched the existing issues

Feature type

User interface/User experience

Problem

The app currently doesn't look too good on bigger form factors such as tablets, foldable devices, etc; as well as phones on landscape mode.

There's also now a lint design warning suggesting not to use the bottom app bar pattern on landscape devices.

Description

We should consider using the Navigation Rail Material Design component on bigger form factors, and keep the usual bottom app bar on smaller devices.

Alternatives?

While we're adopting Compose as per #368, we could consider using the newly introduced Compose Material3 adaptive library and/or Compose Material3 Adaptive Navigation Suite library.

For an example reference, we could take a look at this blog post, written in Aug 2023, a few months before the first alpha was released.

Additional info

No response

@EdricChan03 EdricChan03 added enhancement Enhancements to the Android app. For the web version, please use the other repo instead. user interface Issues/PRs related to the mentioning/fixing of the UI. in progress PRs that are still not finished yet and/ or not yet ready for merging. comp: design Issues/PRs related to the app's design. labels Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: design Issues/PRs related to the app's design. enhancement Enhancements to the Android app. For the web version, please use the other repo instead. in progress PRs that are still not finished yet and/ or not yet ready for merging. user interface Issues/PRs related to the mentioning/fixing of the UI.
Projects
Status: Backlog
Development

No branches or pull requests

1 participant