Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model is not finalizing #111

Open
MostafaGomaa93 opened this issue Nov 13, 2024 · 4 comments
Open

Model is not finalizing #111

MostafaGomaa93 opened this issue Nov 13, 2024 · 4 comments

Comments

@MostafaGomaa93
Copy link
Contributor

Hello @BSchilperoort
I noticed that the model is not finalized with an error message if the model is running for longer periods (e.g. 20 days). I did several tests with different sites but always same problem. I actually can't figure out where is the problem, so would appreciate your help. I attached the model here in case you could test from your side.

NL-Loo_2024-11-13-1159.zip

Screenshot 2024-11-13 170345

@BSchilperoort
Copy link
Contributor

Maybe the model is encountering an error during finalization. Maybe something is going wrong trying to write data to file.

I am not sure if errors are written to a log file, this would be a good improvement for stemmus_scope as it'll make it easier to debug these issues.
e.g. https://nl.mathworks.com/help/matlab/ref/diary.html

@MostafaGomaa93
Copy link
Contributor Author

I run the model through Matlab (without Pystemmusscope) and it runs to the end successfully

@SarahAlidoost
Copy link
Member

I run the model through Matlab (without Pystemmusscope) and it runs to the end successfully

Just to clarify, did you run the model via matlab and bmi interface? the finalize is a bmi function and this block is where the function is used.

Another point, please check if your pystemmusscope installation is based on the main branch in this repo since the newest changes have not been released yet.

@MostafaGomaa93
Copy link
Contributor Author

MostafaGomaa93 commented Nov 14, 2024

Just to clarify, did you run the model via matlab and bmi interface? the finalize is a bmi function and this block is where the function is used.

If I run without BMI, the model runs successfully. If I run through BMI (using Bart notebook or mine), the final step model.finalize() gave an error (error message showed above). Through BMI, the model actually runs to the end, but not all the csv files are generated and the binary files are not deleted.

This link has a model files example (in case you could give it a try from your side)
NL-Loo_2024-11-07-1226.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants