Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker publish action #107

Open
BSchilperoort opened this issue Aug 30, 2024 · 2 comments
Open

Add Docker publish action #107

BSchilperoort opened this issue Aug 30, 2024 · 2 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@BSchilperoort
Copy link
Contributor

In STEMMUS_SCOPE a new docker image is built and pushed by Github Actions upon a new release.

We should add this for this repo as well. However, there is one complication: I have used the model tag as the container tag (I.e. stemmus_scope-grpc4bmi:1.5.0 uses the stemmus_scope:1.5.0 container. The workflow uses the repository's tag/release version, which would be stemmus_scope-grpc4bmi:0.4.0.

@SarahAlidoost
Copy link
Member

SarahAlidoost commented Sep 30, 2024

With actions/github-script , it is possible to fetch the release tag from the other repository, see some related examples here. However, stemmus_scope-grpc4bmi:0.4.0 is fine. The version of the model e.g. 1.6.1 is specified in the Dockerfile. Since Docker installs latest pystemmusscope, it would be better if the tag aligns with the pystemmusscope release, rather than stemmus_scope itself.

@SarahAlidoost SarahAlidoost added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 14, 2024
@SarahAlidoost
Copy link
Member

  • add the GA action
  • add documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants