Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update solveTridiagonalMatrixEquations.m #203

Conversation

MostafaGomaa93
Copy link
Contributor

@MostafaGomaa93 MostafaGomaa93 commented Nov 8, 2023

The model gave the error below

error

Description

The any() function is needed in line 24 -> solveTridiagonalMatrixEquations.m file to let the model run. The change I did is (if any(isnan(SAVEhh)) == 1 || any(~isreal(SAVEhh)))
However, since I am a new user of the model, I don't know if that change will give the same or different results from the main code.

Checklist

  • Add a reference to related issues.
  • @mentions of the person or team responsible for reviewing proposed changes.
  • This pull request has a descriptive title.
  • Code is written according to the guidelines.
  • The checks by MISS_HIT style checker and linter, below the pull request, are successful (green).
  • Documentation is available.
  • Add changes to the changelog file under section Unreleased.
  • Model runs successfully.
  • Ask a meinatainer to re-generate exe file if matlab codes are changed. About how to create an exe file, see exe readme.

The any() function is needed in line 24 -> solveTridiagonalMatrixEquations.m file to let the model run.

However, since I am a new user of the code, I don't know if that change will give the same or different results from the main code.
@MostafaGomaa93 MostafaGomaa93 linked an issue Nov 8, 2023 that may be closed by this pull request
@SarahAlidoost SarahAlidoost self-requested a review November 8, 2023 13:22
Copy link
Member

@SarahAlidoost SarahAlidoost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MostafaGomaa93 thank you for the fix 👍 I tested if the model still runs using exe and octave.

This is nice to see that the name of your branch is very specified i.e. 202-any()-function-is-needed-in-the-solveTridiagonalMatrixEquation.m 👏
But please avoid using syntaxes like () in the future. Some syntaxes are not recognized in bash. See some good practices in naming branches.

@SarahAlidoost SarahAlidoost merged commit be6a9a7 into main Nov 8, 2023
1 check passed
@SarahAlidoost SarahAlidoost deleted the 202-any()-function-is-needed-in-the-solveTridiagonalMatrixEquation.m branch November 8, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model is not running -> issue in the SAVEhh variable
2 participants