Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 100 #197

Merged
merged 17 commits into from
Oct 10, 2023
Merged

Fix issue 100 #197

merged 17 commits into from
Oct 10, 2023

Conversation

SarahAlidoost
Copy link
Member

@SarahAlidoost SarahAlidoost commented Oct 2, 2023 •
edited
Loading

Description

closes #100. I tested this branch with three site data. The results are the same as those generated by the main branch.

Checklist

  • Add a reference to related issues.
  • @mentions of the person or team responsible for reviewing proposed changes.
  • This pull request has a descriptive title.
  • Code is written according to the guidelines.
  • The checks by MISS_HIT style checker and linter, below the pull request, are successful (green).
  • Documentation is available.
  • Add changes to the changelog file under section Unreleased.
  • Model runs successfully.
  • Ask a meinatainer to re-generate exe file if matlab codes are changed. About how to create an exe file, see exe readme.

@SarahAlidoost SarahAlidoost marked this pull request as ready for review October 6, 2023 12:41
BSchilperoort
BSchilperoort approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@BSchilperoort BSchilperoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳
Just some small comments.

Again I assume you tested for any changes in model result.

src/+energy/calculateBoundaryConditions.m Outdated Show resolved Hide resolved
src/+energy/calculateEnergyFluxes.m Outdated Show resolved Hide resolved
@SarahAlidoost
Copy link
Member Author

🥳 Just some small comments.

Thanks for reviewing 😄

Again I assume you tested for any changes in model result.

yes, I mentioned it here.

@SarahAlidoost SarahAlidoost merged commit 9dc322f into main Oct 10, 2023
1 check passed
@SarahAlidoost SarahAlidoost deleted the fix_issue_100 branch October 10, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BSchilperoort BSchilperoort BSchilperoort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Enrgy_sub, move all Enrgy_ functions
2 participants
@SarahAlidoost @BSchilperoort