-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 98 #193
Fix issue 98 #193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, Sarah! I just have some very minor comments.
I tested the code for two sites, two weeks each, and there was no difference at all. I only tested the code with Matlab, I assume you developed this using octave and that needs no test?
Thanks for the review and comment. Yes, I tested the results with octave. Good that you tested with Matlab too. Regarding the syntax compatibility between Matlab and Octave, if there is any problem with Matlab syntax, creating exe file returns an error. |
Co-authored-by: Bart Schilperoort <[email protected]>
Co-authored-by: Bart Schilperoort <[email protected]>
Description
closes #98. I tested this branch with small datasets of three different sites. This branch produces the same results as those from the main branch.
Checklist
Unreleased
.