Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 98 #193

Merged
merged 24 commits into from
Sep 12, 2023
Merged

Fix issue 98 #193

merged 24 commits into from
Sep 12, 2023

Conversation

SarahAlidoost
Copy link
Member

@SarahAlidoost SarahAlidoost commented Aug 7, 2023

Description

closes #98. I tested this branch with small datasets of three different sites. This branch produces the same results as those from the main branch.

Checklist

  • Add a reference to related issues.
  • @mentions of the person or team responsible for reviewing proposed changes.
  • This pull request has a descriptive title.
  • Code is written according to the guidelines.
  • The checks by MISS_HIT style checker and linter, below the pull request, are successful (green).
  • Documentation is available.
  • Add changes to the changelog file under section Unreleased.
  • Model runs successfully.
  • Ask a meinatainer to re-generate exe file if matlab codes are changed. About how to create an exe file, see exe readme.

@SarahAlidoost SarahAlidoost marked this pull request as ready for review September 6, 2023 14:16
Copy link
Contributor

@BSchilperoort BSchilperoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, Sarah! I just have some very minor comments.

I tested the code for two sites, two weeks each, and there was no difference at all. I only tested the code with Matlab, I assume you developed this using octave and that needs no test?

src/+io/define_constants.m Outdated Show resolved Hide resolved
src/+io/define_constants.m Outdated Show resolved Hide resolved
src/StartInit.m Outdated Show resolved Hide resolved
@SarahAlidoost
Copy link
Member Author

Great work, Sarah! I just have some very minor comments.

I tested the code for two sites, two weeks each, and there was no difference at all. I only tested the code with Matlab, I assume you developed this using octave and that needs no test?

Thanks for the review and comment. Yes, I tested the results with octave. Good that you tested with Matlab too. Regarding the syntax compatibility between Matlab and Octave, if there is any problem with Matlab syntax, creating exe file returns an error.

@SarahAlidoost SarahAlidoost merged commit 5decaae into main Sep 12, 2023
1 check passed
@SarahAlidoost SarahAlidoost deleted the fix_issue_98 branch September 12, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor h_sub, move all h_ functions
2 participants