Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 97 #186

Merged
merged 12 commits into from
Jun 30, 2023
Merged

Fix issue 97 #186

merged 12 commits into from
Jun 30, 2023

Conversation

SarahAlidoost
Copy link
Member

@SarahAlidoost SarahAlidoost commented Jun 20, 2023

Description

closes #97

Some part is fixed in EcoExtreML/STEMMUS_SCOPE_Processing#88

Update executable file

Please re-generate exe file if matlab codes are changed. About how to create an exe file, see exe readme.

Checklist

  • Add a reference to related issues.
  • @mentions of the person or team responsible for reviewing proposed changes.
  • This pull request has a descriptive title.
  • Code is written according to the guidelines.
  • The checks by MISS_HIT style checker and linter, below the pull request, are successful (green).
  • Documentation is available.
  • Model runs successfully.

@SarahAlidoost SarahAlidoost marked this pull request as ready for review June 20, 2023 13:01
Copy link
Contributor

@BSchilperoort BSchilperoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sarah, I am quite confused as to what's going on in this code and why.

Could you clear this up, possible with the help of @yijianzeng and @Yunfei-Wang1993 ?

src/STEMMUS_SCOPE.m Outdated Show resolved Hide resolved
src/STEMMUS_SCOPE.m Show resolved Hide resolved
src/STEMMUS_SCOPE.m Outdated Show resolved Hide resolved
src/STEMMUS_SCOPE.m Outdated Show resolved Hide resolved
Copy link
Contributor

@BSchilperoort BSchilperoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! It's good to see there are now fewer lines and fewer variables.
Just two small comments from me.

src/STEMMUS_SCOPE.m Outdated Show resolved Hide resolved
src/STEMMUS_SCOPE.m Show resolved Hide resolved
@SarahAlidoost SarahAlidoost merged commit 2e13e98 into main Jun 30, 2023
1 check passed
@SarahAlidoost SarahAlidoost deleted the fix_issue_97 branch June 30, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Forcing_PARM
3 participants