-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue #163 #174
fix issue #163 #174
Conversation
It would be nice to have a descriptive title of your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I left some comments and address them. Thanks a lot 😄 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to add references, explain the if-statements and loops, make codes clean.
Possible improvement: meaning of input and output variables should be explained
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to add the reference and explanations for the function and variables 👍. Please see my comments in the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Danyang, nice work!
@DanyangYu and @Crystal-szj Thank you for working on the pull request. I noticed that you approved and merged the pull request while the checks were not green. This will reduce the quality of the codes in the main branch. For future pull requests, please make sure that the checks are green before approving and merging them. |
Got it |
Description
Refator the Root_property fuction
Update executable file
Please re-generate exe file if matlab codes are changed. About how to create an exe file, see exe readme.
Checklist
closes #163