Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the findPhreaticSurface function #244

Closed
MostafaGomaa93 opened this issue Jul 26, 2024 · 0 comments
Closed

Remove the findPhreaticSurface function #244

MostafaGomaa93 opened this issue Jul 26, 2024 · 0 comments

Comments

@MostafaGomaa93
Copy link
Contributor

MostafaGomaa93 commented Jul 26, 2024

I was testing the code with variable groundwater depth through time (the main purpose was to track issue 242 for the groundwater temperature) and by coincidence I found out that the function findPhreaticSurface is not working correctly with variable groundwater depth. This function should find the soil layer that includes the phreatic surface (saturated zone) and is used in the groundwater recharge calculations. It is adopted from the FINDTABLE in STEMMUS_MODFLOW. However, the test with variable groundwater depth shows a shift between the indxGWLay and the indxBotmLayer_R (the check in this line) and that shift is expanding through the time (definitions of indxGWLay and the indxBotmLayer_R are here).

I add couple of lines in the calculateGroundwaterRecharge that does similar to the findPhreaticSurface function, but shorter and works correctly with the case of variable groundwater depth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant