New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ModelSettings.KT incorrectly described #206

Open

BSchilperoort opened this issue Nov 15, 2023 · 0 comments

Contributor

BSchilperoort commented Nov 15, 2023

In getModelSettings.m, "KT" is called "Number of time steps". However, this is actually the index of the first time step, minus 1.

It might even be better to remove this from the ModelSettings entirely.

https://github.com/EcoExtreML/STEMMUS_SCOPE/blob/55bfe4e6752a2ab7d035e43d69ba38c22fbef9f8/src/%2Bio/getModelSettings.m#L63C12-L63C12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment