Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value of ML #178

Open
SarahAlidoost opened this issue May 30, 2023 · 2 comments
Open

Value of ML #178

SarahAlidoost opened this issue May 30, 2023 · 2 comments
Labels
code enhancement New feature or request

Comments

@SarahAlidoost
Copy link
Member

In the Dtrmn_Z.m, the variable ML is used as an index for looping over some sets of numbers e.g. for ML = 1:42. Therefore, the value of ML is changing between 1 and 42. On the other hand, ML is also used to create empty matrixes, see here. This is not correct. See related discussions in #95

@SarahAlidoost
Copy link
Member Author

@Crystal-szj I created a new issue for ML here.

@SarahAlidoost SarahAlidoost added the code enhancement New feature or request label May 30, 2023
@Crystal-szj
Copy link
Contributor

@SarahAlidoost Hi Sarah, the variable ML is used as an index for looping, as you mentioned. And, at the end of Dtrmn_Z.m, the value of NL and ML are the same (equal to 54 based on the default soil depth and soil layer thickness settings). I think that's the reason we used ML to initialize the empty matrixes. We can use NL rather than ML to avoid potential bugs.
@Yunfei-Wang1993 @yijianzeng @Lianyu-Yu Please correct me and provide further clarification if I misunderstood the purpose and usage of the variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants