Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BonusMalus selections are not saved/loaded (Affects at least Exceptional Aptitude Morph Trait) #108

Open
andipouf opened this issue Apr 29, 2019 · 3 comments

Comments

@andipouf
Copy link

Can I start out by pointing out how fantastic you are? Your site saved me hours of indifferent reading and kick-started my ability to make connections to the rules and come up with character ideas. The entire crew/party+GM ended up using the builder because of how helpful it is.

The only things I have noticed so far were that it was hit or miss with some gear/items that gave you the ability to have multiples - Which I think you fixed in your most recent patch so thank you!

And that the Morph Positive Trait -Exceptional Aptitude will not keep your selected Aptitude from the dropdown menu. When I first select the trait, it will show Cognition +10 as a default/start of the dropdown list, and when you select a different item from the list, it will shortly change itself back to Cognition.

I hope the details are more helpful than they are annoying to read! And thank you again for keeping this site up!

@EmperorArthur
Copy link
Collaborator

Hi, were you attempting this on a character you loaded, or on a fresh character?

Unfortunately, the creator can experience desyncs between the loaded character and what you see, which comes from the database. Put another way, when you see the large list, that's local copies of database objects. PHP uses references most of the time, so that list is the same one as what's in a brand new character. Unfortunately, when you load a character, that's a brand new version, and the two aren't linked any more.

I'm currently planning a some backend and UI changes to prevent this from happening. The largest thing you will notice is distinct "Ego" and "Morph" pages/tabs which will be much more "add X to your character" instead of something in the middle of a list.

PS: Yes, your local session does indeed have an entire copy of the database as objects. That decision was made before my time.

@andipouf
Copy link
Author

Hello!

I tried a loaded character and a new one when I first encountered this to check all the boxes and I did see that the same thing happened each time when the character was exported or saved. So I even rechecked to see if the drop-down menu stayed on the selected aptitude after leaving the morph section and entering one of the skills sections. When I returned to the morph and the exceptional aptitude option, it had changed itself back to "Cognition".

@EmperorArthur EmperorArthur changed the title Exceptional Aptitude Morph BonusMalus selections are not saved/loaded (Affects at least Exceptional Aptitude Morph Trait) Jun 20, 2019
@EmperorArthur
Copy link
Collaborator

I'm sorry that this is still happening. I have some good news and bad news for you. The good news is I'm pretty sure I've identified the problem.

This is what I believe is the variable that is storing your choice.

The bad news is that variable is not saved. This means any choice where you have to make a selection is not saved! The really annoying part is that I'm going to have to triple check that the variable contains what I want it to, since I at least trying to support loading old saves without issue.

The really bad news is that in looking into this issue I found a larger one (probably related) that breaks the creator if you try to re-visit a background (like BONOBO UPLIFT) after saving/loading and making a choice.

Persistence on your end does work.

I'm just fighting fires, and haven't gotten around to this one yet. My goal is to fight some of these rendering issues by re-doing the frontend and API calls one piece at a time.

I'm prioritizing anything which crashes the creator, or leaves it an an unworkable state.

Keep pestering me when you see this broken in a new release

Just because I'm focusing on massive breaking bugs doesn't mean your issue isn't important. Please just keep bringing it up and I'll see what I can do to fix it going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants