Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONTRIBUTING.md link for PRs is incorrect #5190

Closed
ianchanning opened this issue Nov 27, 2020 · 3 comments
Closed

CONTRIBUTING.md link for PRs is incorrect #5190

ianchanning opened this issue Nov 27, 2020 · 3 comments
Labels
PR requested Issues that can be addressed with a new PR

Comments

@ianchanning
Copy link
Contributor

The contributing link for PRs is broken it goes to https://github.com/CONTRIBUTING.md instead of https://github.com/EbookFoundation/free-programming-books/blob/master/CONTRIBUTING.md

You can see either my recent PR #5189 or the previous one to that #5188 they both have contributing links that go to the wrong place.
@eshellman eshellman added the PR requested Issues that can be addressed with a new PR label Nov 27, 2020
@eshellman
Copy link
Collaborator

I can't reproduce the problem, but I not that the CONTRIBUTING.md link on https://ebookfoundation.github.io/free-programming-books/ doesn't get rendered to HTML

@ianchanning
Copy link
Contributor Author

As far as I can tell its because in the PR template it begins with a /

- [ ] Read our [contributing guidelines](/CONTRIBUTING.md)

@Siddharth-coder13 Siddharth-coder13 mentioned this issue Dec 16, 2020
Merged
5 tasks
@kadhirash
Copy link
Member

Closing as the issue is resolved with PR #5226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PR requested Issues that can be addressed with a new PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ianchanning @eshellman @kadhirash