Support re-enabling actions if they have been disabled. #6210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seb33300
reviewed
May 22, 2024
| @@ -132,6 +132,13 @@ public function disable(string ...$disabledActionNames): self | |||
| return $this; | |||
| } | |||
|
|
|||
| public function enable(string ...$enabledActionNames): self | |||
| { | |||
| $this->dto->enableActions($enabledActionNames); | |||
There was a problem hiding this comment.
Should we also re enable Action::BATCH_DELETE in case Action::DELETE is enabled?
(to be consistent with the disable method)
There was a problem hiding this comment.
I update the code to reflect this.
I also re-enable Action::DELETE if Action::BATCH_DELETE is re-enabled.
dragosprotung
force-pushed
the
feature/enable-action
branch
from
2fd154a
to
436d06f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an action has been disabled, there is no way to reenable it.
This is usefull when having a base controller that gets extended to create different views. If an action should by default be disabled (in the base controller) it will not be possible to reenable it in the extending controller.
Also fixes #5128