Use <fieldset> tag for "Form Panel"

[ThomasLandauer]

Follow-up of #4655

Is there a specific reason why you're introducing the term "Form Panel" at https://symfony.com/bundles/EasyAdminBundle/current/fields.html#form-panels for what is (essentially) a <fieldset>?

Right now, they get rendered as two <div>s:

<div class="field-form_panel">
    <div class="form-panel">

My suggestion would be to replace one of them (or both - don't know what their purpose is) with <fieldset>, and the following one/two with <legend>:

<div class="form-panel-header">
    <div class="form-panel-title">

A positive side effect would be that searching for "EasyAdmin fieldset" (which is what I did before I opened the above issue ;-) would yield a result :-)

[ThomasLandauer]

Just another idea regarding Form Panels:
Allow closing them, to allow having fields outside any Panel:

Date
| -- User -- |
| First Name |
| Last Name  |
--------------
Price

[javiereguiluz]

In my private TODO list I had this "panel -> fieldset" renaming as a possible thing to do. I think this was a mistake ... so your message might be what I needed to finally do this change.

About closing panel, this was a conscious decision. Because of how we define design elements (and future elements that will be included "soon") it's better to not close elements explicitly.

What's the solution then? To open a new empty panel/fieldset:

yield Date
yield Panel('User')
yield FirstName
Yield LastName
yield Panel('')
yield Price

[javiereguiluz]

Closing as fixed in #5932.