Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload to Pypi remaining issues #37

Open
3 of 5 tasks
KrisThielemans opened this issue Oct 27, 2024 · 5 comments
Open
3 of 5 tasks

Upload to Pypi remaining issues #37

KrisThielemans opened this issue Oct 27, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@KrisThielemans
Copy link
Contributor

KrisThielemans commented Oct 27, 2024

#26 enabled auto-uploading to test_pypi, see https://test.pypi.org/project/petsird/0.0.1, but

@casperdcl @lukepolson I could use some help here :-)

@KrisThielemans KrisThielemans self-assigned this Oct 27, 2024
@casperdcl
Copy link
Member

casperdcl commented Oct 29, 2024

@KrisThielemans I'm only a member under https://github.com/orgs/ETSInitiative/people and not in any team under https://github.com/orgs/ETSInitiative/teams so

  • I can't push branches to this repo
  • I can't self-assign this issue
  • I can't add an environment to this repo's settings for PyPI Trusted Publishing

@casperdcl
Copy link
Member

Also:

  • Wrong README (the one from the python folder)

The root README also seems equally inappropriate (contains instructions for building, which doesn't apply to an already-built PyPI package).

IMO either:

  • move maintainer instructions from ./python/README.md to ./README.md,
  • or write a ./python/README.pypi.md
  • Author list needs to be completed.

More important is a maintainer contact. Is there a single email address? Ideally @etsinitiative.org. Horrifyingly, https://etsinitiative.org/contact lists nothing.

  • Currently only uploading the python files. Do we need 2 packages (python and cpp?)

C++ doesn't exactly have a packaging ecosystem like Python. I'd recommend uploading as GitHub release art[ie]facts.

Alternatively, I've seen other projects (ab)use PyPI to distribute C++ packages.

@KrisThielemans
Copy link
Contributor Author

@KrisThielemans I'm only a member under https://github.com/orgs/ETSInitiative/people and not in any team under https://github.com/orgs/ETSInitiative/teams so

maintainer now, also of ETSIhackers

@casperdcl
Copy link
Member

I still don't have permissions as https://github.com/orgs/ETSInitiative/teams/maintainers/repositories is empty.

@KrisThielemans
Copy link
Contributor Author

didn't know this was a separate step. done now.

@casperdcl casperdcl added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request and removed documentation Improvements or additions to documentation labels Oct 29, 2024
@casperdcl casperdcl mentioned this issue Oct 30, 2024
@KrisThielemans KrisThielemans changed the title Upload to Pypi problems Upload to Pypi remaining issues Nov 1, 2024
@KrisThielemans KrisThielemans removed the bug Something isn't working label Nov 1, 2024
This was referenced Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants