Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the creation of a TUV-x photolysis calculator to the MUSICA wrapper #108

Merged
merged 33 commits into from
Sep 4, 2024
Merged

Add the creation of a TUV-x photolysis calculator to the MUSICA wrapper #108

merged 33 commits into from
Sep 4, 2024

Conversation

boulderdaze
Copy link
Collaborator

@boulderdaze boulderdaze commented Aug 9, 2024 •
edited
Loading

Closes #75

  • Added the rudimentary wrapper for TUV-X
  • Updated the latest MICM APIs (including enabling multiple grid cells)
  • Added unit tests for MICM utils

Solver results

 Solver state: Convergence Exceeded Max Steps
 Function calls:   1996
 Jacobian updates: 995
 Number of steps:  1001
 Accepted:         995
 Rejected:         0
 Decompositions:   1001
 Solves:           3003
 Singular:         1996

Currently the solution doesn't converge. It's possible that the incorrect mapping between species and concentrations caused the convergence failure. We're going to look into this in a separate issue.

@boulderdaze boulderdaze changed the base branch from main to development August 9, 2024 17:51
@boulderdaze boulderdaze marked this pull request as ready for review August 24, 2024 04:27
mattldawson
mattldawson approved these changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@mattldawson mattldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

nusbaume
nusbaume requested changes Aug 31, 2024
View reviewed changes
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I do have some comments and questions, but they should all be pretty minor. Also if I made a comment on any code that is temporary or that is going to be replaced in an upcoming PR just let me know. Thanks!

musica/micm/micm_util.F90 Outdated Show resolved Hide resolved
musica/micm/micm_util.F90 Outdated Show resolved Hide resolved
musica/micm/micm_util.F90 Outdated Show resolved Hide resolved
musica/micm/micm_util.F90 Outdated Show resolved Hide resolved
musica/musica_ccpp.F90 Outdated Show resolved Hide resolved
musica/musica_ccpp.F90 Outdated Show resolved Hide resolved
musica/musica_ccpp.F90 Outdated Show resolved Hide resolved
musica/micm/musica_ccpp_micm.F90 Outdated Show resolved Hide resolved
musica/tuvx/musica_ccpp_tuvx.F90 Outdated Show resolved Hide resolved
nusbaume
nusbaume approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great to me now, thanks!

@nusbaume nusbaume removed the request for review from peverwhee September 3, 2024 19:59
mattldawson
mattldawson approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@mattldawson mattldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

K20shores
K20shores approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@K20shores K20shores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like good work to me

@boulderdaze boulderdaze merged commit 06e743d into development Sep 4, 2024
1 check passed
@boulderdaze boulderdaze deleted the 75-tuvx-wrapper branch September 4, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattldawson mattldawson mattldawson approved these changes

@K20shores K20shores K20shores approved these changes

@nusbaume nusbaume nusbaume approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TUV-x in MUSICA wrapper
4 participants
@boulderdaze @mattldawson @K20shores @nusbaume