Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change namelist items to remove "rtm" in the names of namelist variables #98

Closed
ekluzek opened this issue Jun 6, 2024 · 2 comments · Fixed by #76
Closed

Change namelist items to remove "rtm" in the names of namelist variables #98

ekluzek opened this issue Jun 6, 2024 · 2 comments · Fixed by #76

Comments

@ekluzek
Copy link
Contributor

ekluzek commented Jun 6, 2024

namelist variables have rtm in the name. This is similar to #97 except here I'm just mentioning namelist variables, which is important to note since they are using facing.

The main reason for having RTM in the names of namelist variables goes back to when RTM was a subroutine call from within CLM. So this is removing an old feature that isn't needed anymore.

This is done in #76

@ekluzek
Copy link
Contributor Author

ekluzek commented Jun 6, 2024

@mvertens I would've had a preference for the rtmhist_* to be changed to hist_* so that all history variables are grouped together. But, that is a small nitpick and we don't want to have to redo testing, so we'll leave it like it is, unless someone really wants to do that on their own.

@mvertens
Copy link
Contributor

mvertens commented Jun 7, 2024

@ekluzek - I agree. I will change this in the new PR.

@mvertens mvertens linked a pull request Jun 7, 2024 that will close this issue
5 tasks
@mvertens mvertens removed a link to a pull request Jun 7, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants