Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert use_fates_lupft to an XML setting #2629

Open
glemieux opened this issue Jun 28, 2024 · 0 comments
Open

Convert use_fates_lupft to an XML setting #2629

glemieux opened this issue Jun 28, 2024 · 0 comments

Comments

@glemieux
Copy link
Contributor

glemieux commented Jun 28, 2024

The use_fates_lupft option sets

  • use_fates_luh
  • use_fates_nocomp
  • use_fates_fixedbiogeo

which is the primary scientific study for this work. This is settling a few things at once for convenience and also making it easier to do the primary setup.

Because it's a conglomeration setting (turning several things on at once), longer term I think it should be moved into an XML setting. Technically it could also be in a build-namelist command line option or a use-case. But, we are deprecating those last two. Leave up to you if setting them all true, but leaving use_fates_lupft to FALSE is OK or not.

Conglomeration settings should also check that the user isn't trying to set this on their own. So for example if the user try's to turn this on -- but turn one of these off individually that should fail.

Originally posted by @ekluzek in #2507 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant