Call Python scripts directly from rxcropmaturity.py

[samsrabin]

There are several places in the RXCROPMATURITY test code (rxcropmaturity.py) where a call is made to subprocess. E.g.:

CTSM/cime_config/SystemTests/rxcropmaturity.py

Lines 388 to 409 in a943377

	# It'd be much nicer to call generate_gdds.main(), but I can't import generate_gdds.
	tool_path = os.path.join(
	self._ctsm_root, "python", "ctsm", "crop_calendars", "generate_gdds.py"
	)
	command = " ".join(
	[
	f"python3 {tool_path}",
	f"--input-dir {input_dir}",
	f"--first-season {first_season}",
	f"--last-season {last_season}",
	f"--sdates-file {sdates_file}",
	f"--hdates-file {hdates_file}",
	f"--output-dir generate_gdds_out",
	f"--skip-crops miscanthus,irrigated_miscanthus",
	]
	)
	stu.run_python_script(
	self._get_caseroot(),
	self._this_conda_env,
	command,
	tool_path,
	)

CTSM/cime_config/SystemTests/systemtest_utils.py

Lines 43 to 54 in a943377

	def run_python_script(caseroot, this_conda_env, command_in, tool_path):
	# First, try with "conda run -n"
	command = cmds_to_run_via_conda(caseroot, f"conda run -n {this_conda_env}", command_in)
	# Run with logfile
	tool_name = os.path.split(tool_path)[-1]
	try:
	with open(tool_name + ".log", "w") as f:
	subprocess.run(
	command, shell=True, check=True, text=True, stdout=f, stderr=subprocess.STDOUT
	)

It would be more robust to import the relevant functions from the scripts in question, then call them directly from Python. I think I had problems with that before, though, which is why I did it this way. The problems might have been related to ctsm_pylib not being available, but I'm not sure.