Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Meier roughness could be connected to dust Prigent roughness streams.. #2349

Closed
ekluzek opened this issue Feb 7, 2024 · 9 comments
Closed
Labels
closed: wontfix We won't fix this issue, because it would be too difficult and/or isn't important enough to fix enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Feb 7, 2024

The Meier roughness work had development that including using the Prigent roughness data with it as an option. Since, this same dataset comes in with the dust work in #1897 it could be connected after that point.

I'm thinking this is a low priority and maybe something that would happen after CESM3. Connecting the software to do this won't be hard, but it will need someone to evaluate the science. It could be straightforward though since the Meier paper could be used to verify that results are similar in the latest version. So it doesn't necessarily need extensive scientific analysis, nor extensive scientific research.

@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability priority: low Background task that doesn't need to be done right away. type: -discussion next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Feb 7, 2024
@wwieder
Copy link
Contributor

wwieder commented Feb 7, 2024

Thanks for remembering this, Erik. Is Prigent dataset also optional for the dust work?

@ekluzek
Copy link
Collaborator Author

ekluzek commented Feb 7, 2024

It's currently on by default with Leung_2023. Technically it can be turned off, but it's not obvious how you do that. I'll make it more obvious on how to turn it on or off though when dust comes in. Since it's something that can be used for both it should be considered independent of either. That might make a small difference in how it comes in...

@ekluzek ekluzek removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Feb 15, 2024
@ekluzek
Copy link
Collaborator Author

ekluzek commented Feb 15, 2024

Research question and something probably post CESM3.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Feb 15, 2024

@olyson will look at the Meier paper to see if it was an important contribution and easy to follow. It might be easy to implement and check, if so we might do it.

@olyson
Copy link
Contributor

olyson commented Feb 15, 2024

Reviewing the Meier paper with respect to this, they did run a one-off experiment with the Prigent roughness, however, they didn't show any plots isolating the effects of Prigent roughness. Rather they discussed it indirectly by comparing results from a roughness simulation without Prigent (CLM-Z0) to a control and a comparison of roughness including Prigent (CLMZ0C) compared to the same control. They concluded that "Accordingly, the response in the LST DTR tends to be slightly smaller in magnitude in CLM-Z0C than in CLM-Z0. Overall, there is however no major difference between CLMZ0C and CLM-Z0." So I would conclude that this isn't an important/major contribution. If we do implement however, we would have consistency between the dust and Meier parameterizations.

@wwieder
Copy link
Contributor

wwieder commented Feb 16, 2024

Thanks for looking into this, @olyson. I'm not sure we gain much beyond satisfaction by using the dataset consistently for dust and roughness. With limited scientific gains, I'm inclined to close this issue with a won't fix label. What do others think?

@ekluzek
Copy link
Collaborator Author

ekluzek commented Feb 16, 2024

I'm good with either. @dlawrenncar also looked at the Meier work when it was being developed, so would like to hear from him. It might also be good to hear from @dmleung as he is our local expert on the Prigent data.

The main argument I see is that the Prigent dataset gives us observational estimates of roughness over bare rock and soil, while without it we use a constant value everywhere. But, yes if it doesn't make much of a difference is it worthwhile? Also for Paleo climate we'll have to NOT use it, as it's from 2012 satellite observations.

I did look at the Meier roughness issue and PR and didn't see much I thought worth sharing. But, I link them below..

@dmleung did have a PDF that talks about the Prigent datasets (both 2005 and 2012). It's mostly a comparison between the two, but also gives some information on them.

#1596 (comment)

#1596
#1316

@dlawrenncar
Copy link
Contributor

dlawrenncar commented Feb 16, 2024 via email

@ekluzek ekluzek removed the priority: low Background task that doesn't need to be done right away. label Feb 22, 2024
@ekluzek ekluzek added the closed: wontfix We won't fix this issue, because it would be too difficult and/or isn't important enough to fix label Feb 22, 2024
@ekluzek
Copy link
Collaborator Author

ekluzek commented Feb 22, 2024

Closing as a wontfix for now

@ekluzek ekluzek closed this as not planned Won't fix, can't repro, duplicate, stale Feb 22, 2024
@samsrabin samsrabin added the science Enhancement to or bug impacting science label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed: wontfix We won't fix this issue, because it would be too difficult and/or isn't important enough to fix enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science
Projects
Development

No branches or pull requests

5 participants