Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new auxiliary history file for cplhist test with ndep data #1844

Open
adrifoster opened this issue Sep 2, 2022 · 7 comments
Open
Assignees

Comments

@adrifoster
Copy link
Collaborator

Brief summary of bug

Now that we are reading in ndep data for cplhist cases, we need to update the auxiliary history file that we use for test SMS_D_Ld1_PS.f09_g17.I1850Clm50BgcSpinup.cheyenne_intel.clm-cplhist

This also means that old histaux files are no longer compatible with the latest CDEPS (and CTSM, when we update externals).

General bug information

CTSM version you are using: ctsm5.1.dev106

Does this bug cause significantly incorrect results in the model's science? No

Configurations affected: cplhist

To do

@mvertens is planning to run a short F compset to write out new histaux files with ndep data. We then need to update the testdefs for the above test to reference these new files.

@billsacks
Copy link
Member

We'll need to use the upcoming new DATM CPLHIST mode for CMEPS-style cplhist data (which will be called something like CPLHISTCMEPS). This mode isn't implemented yet, but probably will be soon.

@jedwards4b
Copy link
Contributor

I'm a bit confused about this - the lnd_in namelist includes an ndep stream file:
/glade/p/cesmdata/cseg/inputdata/lnd/clm2/ndepdata/fndep_clm_WACCM6_CMIP6piControl001_y21-50avg_1850monthly_0.95x1.25_c180802.nc

Is datm also supposed to provide an ndep data stream? How does that work?

@billsacks
Copy link
Member

@jedwards4b very good question. We were just discussing this at yesterday's ctsm-software meeting and realizing we're all confused about the current state of affairs. I know @mvertens explained it to me a month or two ago, but I forget now. The short story is that we're in a state of transition from CTSM reading ndep itself to always getting it from DATM/CAM, but this isn't fully in place yet, and we need to investigate or hear from @mvertens where we are getting ndep from in different situations currently.

But for the purpose of this issue, the relevant point is that I think CDEPS's DATM now always expects an ndep field.

@mvertens
Copy link

@jedwards4b @billsacks - to clarify the situation - datm always sends ndep right now - but clm is not yet listening to it. The issue is that cam also needs to send ndep in non-waccm cases and so needs to read in ndep the way that clm does when its not computed prognostically. I started putting in the hooks into cam to do this but did not get a chance to finish it before I left. So there were 3 steps to the plan:

  1. Have datm always send ndep
  2. Have cam always send ndep
  3. Have clm no longer read in ndep but receive it from either datm or cam

Does that make sense? I think the next step is to do 2. I can try to take that on. Please let me know if everyone agrees with this.

@billsacks
Copy link
Member

Thanks a lot for clarifying, and for all of your work on this @mvertens !

@billsacks
Copy link
Member

Just a quick summary from the discussion I just had with @mvertens - The big challenge right now is that there is a lot of complex logic for how CTSM determines the right forcings & forcing years to use for NDEP in various cases, based on the use case, sim_year and sim_year_range. @mvertens is going to work through how to transfer this logic to DATM and CAM.

@billsacks
Copy link
Member

I was wondering how @olyson managed to get cplhist mode working recently given this issue (see also ESCOMP/CDEPS#230). It looks like he did this by doing:

./xmlchange DATM_PRESNDEP=none

I'll do that in our cplhist test to get it working, but longer-term we'll want to resolve ESCOMP/CDEPS#230 and then remove this workaround.

billsacks added a commit to billsacks/ctsm that referenced this issue May 8, 2023
Make some changes to the cplhist testmod that should fix the cplhist
test, based on testing done by Keith Oleson:
- Point to new cplhist forcing data generated and used by Adam
  Herrington and Keith Oleson
- Use DATM_PRESNDEP=none until
  ESCOMP#1844 is resolved

Also, remove mct cplhist test
billsacks added a commit that referenced this issue May 19, 2023
Fix nuopc cplhist test

Make some changes to the cplhist testmod that fix the cplhist test,
based on testing done by Keith Oleson:
- Point to new cplhist forcing data generated and used by Adam
  Herrington and Keith Oleson
- Use DATM_PRESNDEP=none until
  #1844 is resolved

Also, remove mct cplhist test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants