Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting fire-emission to work with FATES #1045

Open
ekluzek opened this issue Jun 17, 2020 · 8 comments
Open

Getting fire-emission to work with FATES #1045

ekluzek opened this issue Jun 17, 2020 · 8 comments
Assignees
Labels
enhancement new capability or improved behavior of existing capability priority: low Background task that doesn't need to be done right away. science Enhancement to or bug impacting science

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Jun 17, 2020

Currently fire-emissions from CTSM into CAM can only work for CN or BGC modes and NOT with FATES. As a longer term goal we need FATES to be able to send fire-emissions from CTSM to the coupler and into CAM-Chem.

@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability priority: low Background task that doesn't need to be done right away. tag: enh - new science next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Jun 17, 2020
@ekluzek ekluzek self-assigned this Jun 17, 2020
@billsacks billsacks removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Jun 22, 2020
@glemieux
Copy link
Collaborator

Reviewing issues I believe this is related to NGEET/fates#163

@ekluzek
Copy link
Collaborator Author

ekluzek commented Jan 26, 2023

@adrifoster noticed that the namelist build doesn't ensure these two can't be turned on together, and as a result cases fail in a hard to understand way. So she is going to remedy this.

@adrifoster
Copy link
Collaborator

thanks @ekluzek this is the error I got for a test that erroneously had -fire_emis and use_fates

cat /scratch/cluster/afoster/tests_0126-104846iz/SMS_D_Mmpi-serial.CLM_USRDAT.I1PtClm51Fates.izumi_nag.clm-default--clm-NEON-FATES-NIWO.GC.0126-104846iz_nag/run/cesm.log.589551.izumi.cgd.ucar.edu.230126-115716
Runtime Error: /home/afoster/CTSM/src/biogeochem/FireEmisFactorsMod.F90, line 76: Subscript 1 of FACTORS (value 16) is out of range (1:14)
Program terminated by fatal error

@adrifoster
Copy link
Collaborator

So I added this check but now this fates test is failing on build because -fire_emis is used (from one of the default clm includes user mods).

One solution would be to grab what is needed from the mimics/clm includes chain and put in this testmod dir. Otherwise I'm not sure how to get around using the necessary mimics, clm, and fates options. @ekluzek can you advise?

Hoping to finish #1932 soon and don't want to keep adding too much to it that is outside the scope of FATES-NEON stuff.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Feb 1, 2023

I see a couple ways to handle this:

  1. Change the include order so that FATES is last and overrides the other settings (and explicitly set CLM_BLDNML_OPTS)
  2. Have a mimics base test-mod that doesn't include the default that can be used by both CTSM-BGC and FATES
  3. Duplicate the mimics test-mod for FATES

Since, right now all that the mimics test mode does is include: default and Cold-Start and sets one namelist variable. I think we should do "3". So the FATES test mod wouldn't reference the other one, but just set

soil_decomp_method = 'MIMICSWieder2015'

explicitly in it.

@billsacks
Copy link
Member

Just FYI: I'm changing the failing test that @adrifoster mentioned in #1045 (comment) to be a _P72x2 test instead of _P144x2 to keep with the goal of having all of our aux_clm tests run on 4 nodes or fewer.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Jul 19, 2023

Note on this here: https://github.com/ESCOMP/CTSM/pull/1959/files#r1168038061. The interface to fire-emission should be neutral in terms of FATES vs. BGC.

@rosiealice
Copy link
Contributor

rosiealice commented Oct 25, 2024

We are working on this here:

NorESMhub#67
and
NorESMhub/fates#7

it is not working yet as we still need to write a mapping for the fire emission species from FATES to CLM. There isn't a big technical barrier, we just haven't done it yet. We will make a PR to ESCOMP once it is functional (to reduce the maintenance of having two open PRs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability priority: low Background task that doesn't need to be done right away. science Enhancement to or bug impacting science
Projects
Status: No status
Development

No branches or pull requests

6 participants