Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output downscaled glacier data in cpl glc hist file #441

Merged
merged 2 commits into from
Mar 30, 2024

Conversation

Katetc
Copy link
Contributor

@Katetc Katetc commented Mar 19, 2024

Description of changes

In order to evaluate coupled CESM runs with no active ice sheets, it is very helpful to output the glacier forcing fields from the coupler on the glacier grid. @mvertens wrote this update to CMEPS to support exporting state to glc, added into the lnd2glc auxiliary file.

Specific notes

Contributors other than yourself, if any: @mvertens

CMEPS Issues Fixed (include github issue #):

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)
bfb with added fields in the glc cpl hist files.

Any User Interface Changes (namelist or namelist defaults changes)? No

Testing performed

Please describe the tests along with the target model and machine(s)
If possible, please also added hashes that were used in the testing

I tested this with various configurations and grids. The output looked like what we (the liwg) need for evaluation. We would like to have this in beta 17 for coupled CESM runs.

@Katetc Katetc requested a review from mvertens March 19, 2024 21:46
@jedwards4b
Copy link
Collaborator

@billsacks @Katetc I thought this was failing because the github test needed externals updated, but since #442 passes I have to think that something else is wrong - can you have another look?

@jedwards4b
Copy link
Collaborator

Oh I see -

/home/runner/work/CMEPS/CMEPS/mediator/med_phases_history_mod.F90:556:37:

  556 |     character(len=CS)       :: cvalue
      |                                     1
Error: Unused variable ‘cvalue’ declared at (1) [-Werror=unused-variable]
f951: all warnings being treated as errors

@mvertens mvertens merged commit 823f066 into ESCOMP:main Mar 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants