For T compsets, only run GLC if med_to_glc is true #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the logic for running GLC consistent with runseq_general.py. This change is relevant for the unusual case where a T compset (CISM forced by dlnd) is being run with CISM in noevolve mode: in this case, we don't want to run CISM, and trying to run CISM leads to incorrect behavior in a restart case (which is how this issue was detected). With this change, ERS_D_Ly3.f09_g17_gris4.T1850Gg.derecho_intel.cism-noevolve passes.
|
@Katetc can you please confirm that this solves your issue with @jedwards4b I'm assigning you in order to have an official CMEPS gatekeeper as the official assignee. |
jedwards4b
approved these changes
Dec 27, 2023
This was referenced Dec 27, 2023
|
Hi everybody, this code update fixes the test in my sandbox. Thanks for your help @billsacks and @jedwards4b ! |
|
Thanks a lot @Katetc ! @jedwards4b I think this is ready to merge whenever you feel is a good time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This makes the logic for running GLC consistent with runseq_general.py. This change is relevant for the unusual case where a T compset (CISM forced by dlnd) is being run with CISM in noevolve mode: in this case, we don't want to run CISM, and trying to run CISM leads to incorrect behavior in a restart case (which is how this issue was detected).
With this change,
ERS_D_Ly3.f09_g17_gris4.T1850Gg.derecho_intel.cism-noevolve passes.
Specific notes
Contributors other than yourself, if any: @Katetc
CMEPS Issues Fixed (include github issue #): none
Are changes expected to change answers? No - bfb (except for the unusual case of a T compset with noevolve CISM)
Any User Interface Changes (namelist or namelist defaults changes)? No
Testing performed
ERS_D_Ly3.f09_g17_gris4.T1850Gg.derecho_intel.cism-noevolve
Using ESCOMP/CISM-wrapper@bf0b382