Rename ufs related coupling modes; replace nems with ufs #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* change nems to ufs * update docs
jedwards4b
approved these changes
Nov 7, 2023
| @@ -68,15 +68,15 @@ subroutine esmFldsExchange_nems(gcomp, phase, rc) | |||
| if (chkerr(rc,__LINE__,u_FILE_u)) return | |||
|
|
|||
| ! Set maptype according to coupling_mode | |||
| if (trim(coupling_mode) == 'nems_orig' .or. trim(coupling_mode) == 'nems_orig_data') then | |||
| if (trim(coupling_mode) == 'ufs.nfrac' .or. trim(coupling_mode) == 'ufs.nfrac.aoflux') then | |||
| maptype = mapnstod_consf | |||
There was a problem hiding this comment.
Can you double check these. I see ufs.nfrac, ufs.nfrac.aoflux and ufs.frac.aoflux - are all of these correct?
| @@ -47,7 +47,7 @@ module med_internalstate_mod | |||
| character(len=CS), public :: glc_name = '' | |||
|
|
|||
| ! Coupling mode | |||
| character(len=CS), public :: coupling_mode ! valid values are [cesm,nems_orig,nems_frac,nems_orig_data,hafs,nems_frac_aoflux,nems_frac_aoflux_sbs] | |||
| character(len=CS), public :: coupling_mode ! valid values are [cesm,ufs.nfrac,ufs.frac,ufs.nfrac.aoflux,ufs.frac.aoflux,hafs] | |||
There was a problem hiding this comment.
I guess this answers my previous question.
There was a problem hiding this comment.
Yes, the original names have just been replaced with more explicit names that reflect how or when a mode is used in ufs.
mvertens
approved these changes
Nov 7, 2023
uturuncoglu
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Includes changes recently committed to https://github.com/NOAA-EMC/CMEPS
Specific notes
The non-CESM coupling modes have been clarified and renamed to use "ufs" instead of "nems".
The
esmFldsExchange_nems_modhas be renamed toesmFields_Exchange_ufs_modDocumentation has been updated.
Contributors other than yourself, if any:
CMEPS Issues Fixed (include github issue #):
Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)
Any User Interface Changes (namelist or namelist defaults changes)?
Testing performed
Please describe the tests along with the target model and machine(s)
If possible, please also added hashes that were used in the testing
Changes have been tested and committed in UFS.