Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UFS-specific modifications #411

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Oct 7, 2023

Description of changes

Includes changes recently committed to https://github.com/NOAA-EMC/CMEPS

Specific notes

The SR med_phases_prep_ocn_custom_nems is removed because of the following changes:

  • Evap rate is now sent from ATM, allowing for removal of conversion from latent->evap
  • Stresses and sensible heat flux are now exported from ATM with correct sign
  • The ocean albedo calculation is now implemented in UFS, allowing removal of the custom SW merges

The module esmFldsExchange_nems has been refactored to be more concise and generic.
Unnecessary coupling_mode conditionals were removed where possible

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)

  • should be B4B for CESM

Any User Interface Changes (namelist or namelist defaults changes)?

  • no

Testing performed

Changes have been tested and committed in UFS.

DeniseWorthen and others added 4 commits August 14, 2023 16:19
* account for taux,y sign change from atm
* remove custom merge related solely to need to change sign
* change sign for faxa_sen to match ATM export
* use evap from atm directly
* flux_albav moved to _init
* use_nextswcday for using clock instead of scalar field
* min_albedo for setting min albedo used max(min_albedo,....)
* giving a min_albedo value sets logical use_min_albedo, otherwise
false and min_albedo=0
* set mean albdif and albdir via config. If not present, defaults to
current values
* clean up ufs fields exchange by consolidating logical blocks
* remove extraneous trim on fldname variables
* remove conditionals on mediator fields
@jedwards4b jedwards4b merged commit 31b7da6 into ESCOMP:main Oct 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants