Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase stream filename length to CX (512) from CL (256) #265

Merged
merged 4 commits into from
Mar 30, 2024

Conversation

ekluzek
Copy link
Collaborator

@ekluzek ekluzek commented Mar 26, 2024

Description of changes

Increase stream filename lengths to shr_kind_CX
Also update component test specifications for derecho

Specific notes

Contributors other than yourself, if any: None (was discussed in the CTSM SE and CSEG groups though)

CDEPS Issues Fixed (include github issue #):
Fixes #263

Are there dependencies on other component PRs (if so list): No

Are changes expected to change answers (bfb, different to roundoff, more substantial): bfb

Any User Interface Changes (namelist or namelist defaults changes): No

Testing performed (e.g. aux_cdeps, CESM prealpha, etc): aux_clm

Hashes used for testing:

based on cdeps1.0.28

CTSM branch:ekluzek:mergetodev174
share1.0.18
cmeps0.14.50
cime6.0.217_httpsbranch03
ccs_config_cesm0.0.92

@ekluzek ekluzek requested a review from jedwards4b March 26, 2024 16:44
@ekluzek ekluzek added enhancement New feature or request answers are bfb Responsibility: CTSM Responsibility to manage and accomplish this issue is the CTSM Software group labels Mar 26, 2024
@ekluzek
Copy link
Collaborator Author

ekluzek commented Mar 26, 2024

@jedwards4b and @fischer-ncar let me know if there is more testing I should do.

It looks like the aux_cdeps test list right now is just setup for Cheyenne and not Derecho (see #266). I could make that change and then run aux_cdeps if you like.

@fischer-ncar
Copy link
Collaborator

@ekluzek it would be great if you could update the tests to derecho.

@mvertens mvertens merged commit 9b92a2b into ESCOMP:main Mar 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answers are bfb enhancement New feature or request Responsibility: CTSM Responsibility to manage and accomplish this issue is the CTSM Software group
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase stream filename lengths from shr_kind_cl to shr_kind_cx
3 participants