Skip to content

Commit

Permalink
Increase stream filename length to CX (512) from CL (256) (#265)
Browse files Browse the repository at this point in the history
* Increase stream filename length to CX (512) from CL (256)

* Move testlist from cheyenne to derecho resolving #265

* Change more references of Cheyenne to Derecho in test lists and in datm document

* Remove _Vnuopc in testlists since NUOPC is the default and this is unneeded
  • Loading branch information
ekluzek committed Mar 30, 2024
1 parent 098e604 commit 9b92a2b
Show file tree
Hide file tree
Showing 9 changed files with 63 additions and 63 deletions.
54 changes: 27 additions & 27 deletions datm/cime_config/testdefs/testlist_datm.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,108 +3,108 @@

<test compset="2000_DATM%QIA_SLND_DICE%SSMI_DOCN%DOM_SROF_SGLC_SWAV" grid="T42_T42" name="SMS_Ln9_P1" testmods="datm/scam">
<machines>
<machine name="cheyenne" compiler="intel" category="aux_cdeps"/>
<machine name="derecho" compiler="intel" category="aux_cdeps"/>
</machines>
</test>
<test compset="2000_DATM%QIA_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP" grid="f10_f10_mg37" name="SMS_Vnuopc_Ld5">
<test compset="2000_DATM%QIA_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP" grid="f10_f10_mg37" name="SMS_Ld5">
<machines>
<machine name="cheyenne" compiler="intel" category="aux_cdeps"/>
<machine name="derecho" compiler="intel" category="aux_cdeps"/>
</machines>
<options>
<option name="wallclock"> 00:10:00 </option>
</options>
</test>
<test compset="2000_DATM%CRUv7_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP" grid="f10_f10_mg37" name="SMS_Vnuopc_Ld5">
<test compset="2000_DATM%CRUv7_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP" grid="f10_f10_mg37" name="SMS_Ld5">
<machines>
<machine name="cheyenne" compiler="intel" category="aux_cdeps"/>
<machine name="derecho" compiler="intel" category="aux_cdeps"/>
</machines>
<options>
<option name="wallclock"> 00:10:00 </option>
</options>
</test>
<test compset="HIST_DATM%GSWP3v1_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP" grid="f10_f10_mg37" name="SMS_Vnuopc_Ld5">
<test compset="HIST_DATM%GSWP3v1_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP" grid="f10_f10_mg37" name="SMS_Ld5">
<machines>
<machine name="cheyenne" compiler="intel" category="aux_cdeps"/>
<machine name="derecho" compiler="intel" category="aux_cdeps"/>
</machines>
<options>
<option name="wallclock"> 00:10:00 </option>
</options>
</test>
<test compset="1850_DATM%GSWP3v1_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP" grid="f10_f10_mg37" name="SMS_Vnuopc_Ld5">
<test compset="1850_DATM%GSWP3v1_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP" grid="f10_f10_mg37" name="SMS_Ld5">
<machines>
<machine name="cheyenne" compiler="intel" category="aux_cdeps"/>
<machine name="derecho" compiler="intel" category="aux_cdeps"/>
</machines>
<options>
<option name="wallclock"> 00:10:00 </option>
</options>
</test>
<test compset="2010_DATM%GSWP3v1_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP" grid="f10_f10_mg37" name="SMS_Vnuopc_Ld5">
<test compset="2010_DATM%GSWP3v1_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP" grid="f10_f10_mg37" name="SMS_Ld5">
<machines>
<machine name="cheyenne" compiler="intel" category="aux_cdeps"/>
<machine name="derecho" compiler="intel" category="aux_cdeps"/>
</machines>
<options>
<option name="wallclock"> 00:10:00 </option>
</options>
</test>
<test compset="SSP585_DATM%GSWP3v1_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP" grid="f10_f10_mg37" name="SMS_Vnuopc_Ld5">
<test compset="SSP585_DATM%GSWP3v1_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP" grid="f10_f10_mg37" name="SMS_Ld5">
<machines>
<machine name="cheyenne" compiler="intel" category="aux_cdeps"/>
<machine name="derecho" compiler="intel" category="aux_cdeps"/>
</machines>
<options>
<option name="wallclock"> 00:10:00 </option>
</options>
</test>
<test compset="2000_DATM%NLDAS2_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP" grid="f10_f10_mg37" name="SMS_Vnuopc_Ld5">
<test compset="2000_DATM%NLDAS2_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP" grid="f10_f10_mg37" name="SMS_Ld5">
<machines>
<machine name="cheyenne" compiler="intel" category="aux_cdeps"/>
<machine name="derecho" compiler="intel" category="aux_cdeps"/>
</machines>
<options>
<option name="wallclock"> 00:10:00 </option>
</options>
</test>
<test compset="2000_DATM%NYF_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP" grid="T62_g17" name="SMS_Vnuopc_Ld5">
<test compset="2000_DATM%NYF_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP" grid="T62_g17" name="SMS_Ld5">
<machines>
<machine name="cheyenne" compiler="intel" category="aux_cdeps"/>
<machine name="derecho" compiler="intel" category="aux_cdeps"/>
</machines>
<options>
<option name="wallclock"> 00:10:00 </option>
</options>
</test>
<test compset="2000_DATM%IAF_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP" grid="T62_g17" name="SMS_Vnuopc_Ld5">
<test compset="2000_DATM%IAF_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP" grid="T62_g17" name="SMS_Ld5">
<machines>
<machine name="cheyenne" compiler="intel" category="aux_cdeps"/>
<machine name="derecho" compiler="intel" category="aux_cdeps"/>
</machines>
<options>
<option name="wallclock"> 00:10:00 </option>
</options>
</test>
<test compset="2000_DATM%JRA_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP" grid="TL319_t061" name="SMS_Vnuopc_Ld5">
<test compset="2000_DATM%JRA_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP" grid="TL319_t061" name="SMS_Ld5">
<machines>
<machine name="cheyenne" compiler="intel" category="aux_cdeps"/>
<machine name="derecho" compiler="intel" category="aux_cdeps"/>
</machines>
<options>
<option name="wallclock"> 00:10:00 </option>
</options>
</test>
<test compset="2000_DATM%JRA-1p4-2018_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP" grid="TL319_t061" name="SMS_Vnuopc_Ld5">
<test compset="2000_DATM%JRA-1p4-2018_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP" grid="TL319_t061" name="SMS_Ld5">
<machines>
<machine name="cheyenne" compiler="intel" category="aux_cdeps"/>
<machine name="derecho" compiler="intel" category="aux_cdeps"/>
</machines>
<options>
<option name="wallclock"> 00:10:00 </option>
</options>
</test>
<test compset="2000_DATM%1PT_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP" grid="1x1_mexicocityMEX" name="SMS_Vnuopc_Ld5_P1" testmods="datm/1PT">
<test compset="2000_DATM%1PT_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP" grid="1x1_mexicocityMEX" name="SMS_Ld5_P1" testmods="datm/1PT">
<machines>
<machine name="cheyenne" compiler="intel" category="aux_cdeps"/>
<machine name="derecho" compiler="intel" category="aux_cdeps"/>
</machines>
<options>
<option name="wallclock"> 00:10:00 </option>
</options>
</test>
<test compset="2000_DATM%ERA5_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP" grid="TL319_t061" name="SMS_Vnuopc_Ld5">
<test compset="2000_DATM%ERA5_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP" grid="TL319_t061" name="SMS_Ld5">
<machines>
<machine name="cheyenne" compiler="intel" category="aux_cdeps"/>
<machine name="derecho" compiler="intel" category="aux_cdeps"/>
</machines>
<options>
<option name="wallclock"> 00:10:00 </option>
Expand Down
8 changes: 4 additions & 4 deletions dice/cime_config/testdefs/testlist_dice.xml
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
<?xml version="1.0"?>
<testlist version="2.0">

<test compset="2000_DATM%NYF_SLND_DICE%SSMI_DOCN%DOM_SROF_SGLC_SWAV_SESP" grid="T62_g17" name="SMS_Vnuopc_Ld5">
<test compset="2000_DATM%NYF_SLND_DICE%SSMI_DOCN%DOM_SROF_SGLC_SWAV_SESP" grid="T62_g17" name="SMS_Ld5">
<machines>
<machine name="cheyenne" compiler="intel" category="aux_cdeps"/>
<machine name="derecho"compiler="intel" category="aux_cdeps"/>
</machines>
<options>
<option name="wallclock"> 00:10:00 </option>
</options>
</test>
<test compset="2000_DATM%NYF_SLND_DICE%IAF_DOCN%DOM_SROF_SGLC_SWAV_SESP" grid="T62_g17" name="SMS_Vnuopc_Ld5">
<test compset="2000_DATM%NYF_SLND_DICE%IAF_DOCN%DOM_SROF_SGLC_SWAV_SESP" grid="T62_g17" name="SMS_Ld5">
<machines>
<machine name="cheyenne" compiler="intel" category="aux_cdeps"/>
<machine name="derecho"compiler="intel" category="aux_cdeps"/>
</machines>
<options>
<option name="wallclock"> 00:10:00 </option>
Expand Down
4 changes: 2 additions & 2 deletions dlnd/cime_config/testdefs/testlist_dlnd.xml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?xml version="1.0"?>
<testlist version="2.0">

<test compset="1850_SATM_DLND%SCPL_SICE_SOCN_SROF_SGLC_SWAV" grid="f09_f09_mg17" name="SMS_Vnuopc_Ld3">
<test compset="1850_SATM_DLND%SCPL_SICE_SOCN_SROF_SGLC_SWAV" grid="f09_f09_mg17" name="SMS_Ld3">
<machines>
<machine name="cheyenne" compiler="intel" category="aux_cdeps"/>
<machine name="derecho"compiler="intel" category="aux_cdeps"/>
</machines>
<options>
<option name="wallclock"> 00:10:00 </option>
Expand Down
2 changes: 1 addition & 1 deletion doc/source/datm.rst
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ ERA5 (``datm_datamode_era5_mod.F90``)

.. note::
Due to the high temporal and spatial resoultion of ERA5 dataset, only 2019
data is staged on NCAR's Cheyenne platform under
data is staged on NCAR's Derecho platform under
`$CESMDATAROOT/inputdata/atm/datm7/ERA5`

.. note::
Expand Down
12 changes: 6 additions & 6 deletions docn/cime_config/testdefs/testlist_docn.xml
Original file line number Diff line number Diff line change
@@ -1,25 +1,25 @@
<?xml version="1.0"?>
<testlist version="2.0">

<test compset="2000_DATM%QIA_SLND_SICE_DOCN%DOM_SROF_SGLC_SWAV" grid="f19_f19_mg17" name="SMS_Vnuopc_Ln5">
<test compset="2000_DATM%QIA_SLND_SICE_DOCN%DOM_SROF_SGLC_SWAV" grid="f19_f19_mg17" name="SMS_Ln5">
<machines>
<machine name="cheyenne" compiler="intel" category="aux_cdeps"/>
<machine name="derecho"compiler="intel" category="aux_cdeps"/>
</machines>
<options>
<option name="wallclock"> 00:10:00 </option>
</options>
</test>
<test compset="HIST_DATM%QIA_SLND_SICE_DOCN%DOM_SROF_SGLC_SWAV" grid="f19_f19_mg17" name="SMS_Vnuopc_Ln5">
<test compset="HIST_DATM%QIA_SLND_SICE_DOCN%DOM_SROF_SGLC_SWAV" grid="f19_f19_mg17" name="SMS_Ln5">
<machines>
<machine name="cheyenne" compiler="intel" category="aux_cdeps"/>
<machine name="derecho"compiler="intel" category="aux_cdeps"/>
</machines>
<options>
<option name="wallclock"> 00:10:00 </option>
</options>
</test>
<test compset="2000_DATM%QIA_SLND_SICE_DOCN%SOMAQP_SROF_SGLC_SWAV" grid="f19_f19_mg17" name="SMS_Vnuopc_Ln5">
<test compset="2000_DATM%QIA_SLND_SICE_DOCN%SOMAQP_SROF_SGLC_SWAV" grid="f19_f19_mg17" name="SMS_Ln5">
<machines>
<machine name="cheyenne" compiler="intel" category="aux_cdeps"/>
<machine name="derecho"compiler="intel" category="aux_cdeps"/>
</machines>
<options>
<option name="wallclock"> 00:10:00 </option>
Expand Down
4 changes: 2 additions & 2 deletions drof/cime_config/testdefs/testlist_drof.xml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?xml version="1.0"?>
<testlist version="2.0">

<test compset="2000_SATM_SLND_SICE_SOCN_DROF%NYF_SGLC_SWAV" grid="f19_g17_rx1" name="SMS_Vnuopc_Ld3">
<test compset="2000_SATM_SLND_SICE_SOCN_DROF%NYF_SGLC_SWAV" grid="f19_g17_rx1" name="SMS_Ld3">
<machines>
<machine name="cheyenne" compiler="intel" category="aux_cdeps"/>
<machine name="derecho"compiler="intel" category="aux_cdeps"/>
</machines>
<options>
<option name="wallclock"> 00:10:00 </option>
Expand Down
4 changes: 2 additions & 2 deletions dwav/cime_config/testdefs/testlist_dwav.xml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?xml version="1.0"?>
<testlist version="2.0">

<test compset="2000_SATM_SLND_SICE_SOCN_SROF_SGLC_DWAV%CLIMO" grid="ww3a" name="SMS_Vnuopc_Ld2">
<test compset="2000_SATM_SLND_SICE_SOCN_SROF_SGLC_DWAV%CLIMO" grid="ww3a" name="SMS_Ld2">
<machines>
<machine name="cheyenne" compiler="intel" category="aux_cdeps"/>
<machine name="derecho"compiler="intel" category="aux_cdeps"/>
</machines>
<options>
<option name="wallclock"> 00:10:00 </option>
Expand Down
22 changes: 11 additions & 11 deletions streams/dshr_strdata_mod.F90
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ module dshr_strdata_mod
use ESMF , only : ESMF_REGION_TOTAL, ESMF_FieldGet, ESMF_TraceRegionExit, ESMF_TraceRegionEnter
use ESMF , only : ESMF_LOGMSG_INFO, ESMF_LogWrite
use shr_kind_mod , only : r8=>shr_kind_r8, r4=>shr_kind_r4, i2=>shr_kind_I2
use shr_kind_mod , only : cs=>shr_kind_cs, cl=>shr_kind_cl, cxx=>shr_kind_cxx
use shr_kind_mod , only : cs=>shr_kind_cs, cl=>shr_kind_cl, cxx=>shr_kind_cxx, cx=>shr_kind_cx
use shr_sys_mod , only : shr_sys_abort
use shr_const_mod , only : shr_const_pi, shr_const_cDay, shr_const_spval
use shr_cal_mod , only : shr_cal_calendarname, shr_cal_timeSet
Expand Down Expand Up @@ -389,7 +389,7 @@ subroutine shr_strdata_init(sdat, model_clock, stream_name, rc)
character(CS) :: calendar ! calendar name
integer :: ns ! stream index
integer :: m ! generic index
character(CL) :: fileName ! generic file name
character(CX) :: fileName ! generic file name
integer :: nfld ! loop stream field index
type(ESMF_Field) :: lfield ! temporary
type(ESMF_Field) :: lfield_dst ! temporary
Expand Down Expand Up @@ -677,7 +677,7 @@ subroutine shr_strdata_get_stream_nlev(sdat, stream_index, rc)
type(ESMF_VM) :: vm
type(file_desc_t) :: pioid
integer :: rcode
character(CL) :: filename
character(CX) :: filename
integer :: dimid
integer :: stream_nlev
character(*), parameter :: subname = '(shr_strdata_set_stream_domain) '
Expand All @@ -694,7 +694,7 @@ subroutine shr_strdata_get_stream_nlev(sdat, stream_index, rc)
if (sdat%mainproc) then
call shr_stream_getData(sdat%stream(stream_index), 1, filename)
end if
call ESMF_VMBroadCast(vm, filename, CL, 0, rc=rc)
call ESMF_VMBroadCast(vm, filename, CX, 0, rc=rc)
rcode = pio_openfile(sdat%pio_subsystem, pioid, sdat%io_type, trim(filename), pio_nowrite)
rcode = pio_inq_dimid(pioid, trim(sdat%stream(stream_index)%lev_dimname), dimid)
rcode = pio_inq_dimlen(pioid, dimid, stream_nlev)
Expand Down Expand Up @@ -726,7 +726,7 @@ subroutine shr_strdata_get_stream_domain(sdat, stream_index, fldname, flddata, r
type(var_desc_t) :: varid
type(file_desc_t) :: pioid
integer :: rcode
character(CL) :: filename
character(CX) :: filename
type(io_desc_t) :: pio_iodesc
real(r4), allocatable :: data_real(:)
real(r8), allocatable :: data_double(:)
Expand All @@ -743,7 +743,7 @@ subroutine shr_strdata_get_stream_domain(sdat, stream_index, fldname, flddata, r
if (sdat%mainproc) then
call shr_stream_getData(sdat%stream(stream_index), 1, filename)
end if
call ESMF_VMBroadCast(vm, filename, CL, 0, rc=rc)
call ESMF_VMBroadCast(vm, filename, CX, 0, rc=rc)

! Open the file
rcode = pio_openfile(sdat%pio_subsystem, pioid, sdat%io_type, trim(filename), pio_nowrite)
Expand Down Expand Up @@ -1305,10 +1305,10 @@ subroutine shr_strdata_readLBUB(sdat, ns, mDate, mSec, newData, istr, rc)
real(r8) :: rDateM,rDateLB,rDateUB ! model,LB,UB dates with fractional days
integer :: n_lb, n_ub
integer :: i
character(CL) :: filename_lb
character(CL) :: filename_ub
character(CL) :: filename_next
character(CL) :: filename_prev
character(CX) :: filename_lb
character(CX) :: filename_ub
character(CX) :: filename_next
character(CX) :: filename_prev
logical :: find_bounds
character(*), parameter :: subname = '(shr_strdata_readLBUB) '
character(*), parameter :: F00 = "('(shr_strdata_readLBUB) ',8a)"
Expand Down Expand Up @@ -1432,7 +1432,7 @@ subroutine shr_strdata_readstrm(sdat, per_stream, stream, fldbun_data, &
! local variables
integer :: stream_nlev
type(ESMF_Field) :: field_dst, field_vector_dst
character(CL) :: currfile
character(CX) :: currfile
logical :: fileexists
logical :: fileopen
type(file_desc_t) :: pioid
Expand Down
16 changes: 8 additions & 8 deletions streams/dshr_stream_mod.F90
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ module dshr_stream_mod
! containing those dates.
! -------------------------------------------------------------------------------

use shr_kind_mod , only : r8=>shr_kind_r8, cs=>shr_kind_cs, cl=>shr_kind_cl, cxx=>shr_kind_cxx
use shr_kind_mod , only : r8=>shr_kind_r8, cs=>shr_kind_cs, cl=>shr_kind_cl, cxx=>shr_kind_cxx, cx=>shr_kind_cx
use shr_sys_mod , only : shr_sys_abort
use shr_const_mod , only : shr_const_cday
use shr_string_mod , only : shr_string_leftalign_and_convert_tabs, shr_string_parseCFtunit
Expand Down Expand Up @@ -85,7 +85,7 @@ module dshr_stream_mod

! a useful derived type to use inside shr_streamType ---
type shr_stream_file_type
character(CL) :: name = shr_stream_file_null ! the file name (full pathname)
character(CX) :: name = shr_stream_file_null ! the file name (full pathname)
logical :: haveData = .false. ! has t-coord data been read in?
integer :: nt = 0 ! size of time dimension
integer ,allocatable :: date(:) ! t-coord date: yyyymmdd
Expand Down Expand Up @@ -125,7 +125,7 @@ module dshr_stream_mod
integer :: n_gvd = -1 ! file/sample of greatest valid date
logical :: found_gvd = .false. ! T <=> k_gvd,n_gvd have been set
logical :: fileopen = .false. ! is current file open
character(CL) :: currfile = ' ' ! current filename
character(CX) :: currfile = ' ' ! current filename
integer :: nvars ! number of stream variables
character(CL) :: stream_vectors = 'null' ! stream vectors names
type(file_desc_t) :: currpioid ! current pio file desc
Expand Down Expand Up @@ -379,7 +379,7 @@ subroutine shr_stream_init_from_xml(streamfilename, streamdat, isroot_task, logu
allocate(streamdat(i)%varlist(streamdat(i)%nvars))
endif
do n=1,streamdat(i)%nfiles
call ESMF_VMBroadCast(vm, streamdat(i)%file(n)%name, CL, 0, rc=rc)
call ESMF_VMBroadCast(vm, streamdat(i)%file(n)%name, CX, 0, rc=rc)
if (ChkErr(rc,__LINE__,u_FILE_u)) return
enddo
do n=1,streamdat(i)%nvars
Expand Down Expand Up @@ -1219,7 +1219,7 @@ subroutine shr_stream_readTCoord(strm, k, isroot_task, rc)
integer,optional ,intent(out) :: rc ! return code

! local variables
character(CL) :: fileName ! filename to read
character(CX) :: fileName ! filename to read
integer :: nt
integer :: num,n
integer :: din,dout
Expand Down Expand Up @@ -1513,7 +1513,7 @@ subroutine shr_stream_getCalendar(strm, k, calendar)
type(ESMF_VM) :: vm
integer :: myid
integer :: vid, n
character(CL) :: fileName
character(CX) :: fileName
character(CL) :: lcal
integer(PIO_OFFSET_KIND) :: attlen
integer :: old_handle
Expand Down Expand Up @@ -1745,13 +1745,13 @@ subroutine shr_stream_restIO(pioid, streams, mode)
integer :: maxnt = 0
integer, allocatable :: tmp(:)
integer :: logunit
character(len=CL) :: fname, rfname, rsfname
character(len=CX) :: fname, rfname, rsfname

!-------------------------------------------------------------------------------

if (mode .eq. 'define') then

rcode = pio_def_dim(pioid, 'strlen', CL, dimid_str)
rcode = pio_def_dim(pioid, 'strlen', CX, dimid_str)
do k=1,size(streams)
! maxnfiles is the maximum number of files across all streams
logunit = streams(k)%logunit
Expand Down

0 comments on commit 9b92a2b

Please sign in to comment.