Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read total energy using dycore formula from updated CAM snapshots; update standard names #296

Merged

Conversation

jimmielin
Copy link
Member

Companion issue in CAM: ESCOMP/CAM#1141

Companion PR in CAM: ESCOMP/CAM#1142
this PR in CAM will update snapshots with new variables.

Updates to CAM-SIMA:

- read ncdata variables te_ini_phys, te_ini_dyn, te_cur_phys, te_cur_dyn
- update to standard names per discussion in ESCOMP/CAM#1141
@cacraigucar
Copy link
Collaborator

Please update the CAM standard names spreadsheet: https://docs.google.com/spreadsheets/d/1vpQ_xDZk00Z-_3SpW5N2EF3_FY6K7opNN4cqtSMlbwU/edit?gid=0#gid=0 to contain these updated names, so that future developers have access to the correct names.

Copy link
Collaborator

@cacraigucar cacraigucar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from updating the Standard Names spreadsheet, this PR looks good

@jimmielin
Copy link
Member Author

Thank you @cacraigucar, CCPP standard names spreadsheet updated

@jimmielin jimmielin merged commit 27eacea into ESCOMP:development Sep 26, 2024
8 checks passed
@jimmielin jimmielin deleted the hplin/total_energy_snapshot_read branch September 26, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This PR was created to fix a specific bug.
Projects
Status: Tag
Development

Successfully merging this pull request may close these issues.

3 participants